Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply Recursion #10

Closed
Neshura87 opened this issue Sep 14, 2023 · 5 comments
Closed

Reply Recursion #10

Neshura87 opened this issue Sep 14, 2023 · 5 comments

Comments

@Neshura87
Copy link

See: https://bookwormstory.social/comment/716520

You should probably fix that ASAP or instances will start blocking the bot for spam

@faintbeep
Copy link

Looks like the latest commit accidentally removed the code which actually changes the youtube link to a piped link, so the bot comments with the same youtube link and then starts replying to itself.

@Asudox
Copy link

Asudox commented Sep 14, 2023

I guess it can be fixed with a simple ID check to see if the comment its replying to is its own or not. Might open a PR for this if I have the time today.

@anghelos
Copy link

I guess it can be fixed with a simple ID check to see if the comment its replying to is its own or not.

It shouldn't be posting a YouTube link at all in the first place.

@CDeLeon94
Copy link
Contributor

CDeLeon94 commented Sep 14, 2023

I'm not a TS person, but my take is:

The logic of Lines ~104-114 needs to be moved copied into findYoutubeLinks() or to another function that is applied to the list that comes out of findYoutubeLinks()

@Asudox
Copy link

Asudox commented Sep 14, 2023

I guess it can be fixed with a simple ID check to see if the comment its replying to is its own or not.

It shouldn't be posting a YouTube link at all in the first place.

Oh yeah, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants