Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] [BUG]Lyrics do not scroll at the correct speed when Rate is adjusted #422

Closed
SilentTempest83 opened this issue Sep 15, 2021 · 3 comments
Assignees
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Driver Problem A driver or module on the operating system is not playing nice! Engine: Gameplay Gameplay Related Issues Engine: Lyrics Affects the Lyric Display Module Engine: Sound Affects sound, sync, playback, music etc Status: Solved! This one is done! Type: Bug Something is broken in the code Type: Upstream Bug Bug inherited from upstream

Comments

@SilentTempest83
Copy link

What you're using

Lyrics from LRC files do not scroll at the appropriate speed during game play when Rate is set to values other than 1.0x
Lyrics scroll slower than expected and lines fail to complete scrolling before advancing to the following line when rate is adjusted downward, whereas lyrics scroll too quickly and lines complete scrolling before corresponding audio when rate is adjusted upward.
Issue is present in all builds newer than Alpha 4.9.0 up to current version Alpha 4.9.10. Issue has been tested on Windows builds on 2 separate machines.

Expected behavior

Lyrics will scroll at the same speed as the Rate that is set so that properly timed lyrics will remain in sync with audio at whatever Rate value is set.

VIDEO EXAMPLE OF BEHAVIOR:
https://youtu.be/KFAvApKxtVg

@DarkBahamut162
Copy link

I checked it myself on my own theme and can confirm it to be the case.
It seemed almost like in #411 (mentioned in Speed Oddities) how the rate gets applied twice over. But this time, it happens to everythere (SampleRates don't seem to matter here this time, Tested with 48kHz & 44.1kHz songs, Couldn't find anything lower to check if their effects are worse or not)

@Scraticus Scraticus added Type: Bug Something is broken in the code Engine: Driver Problem A driver or module on the operating system is not playing nice! Engine: Gameplay Gameplay Related Issues Engine: Sound Affects sound, sync, playback, music etc Engine: Lyrics Affects the Lyric Display Module labels Oct 9, 2021
@MrThatKid MrThatKid added Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) labels May 24, 2022
@Scraticus Scraticus self-assigned this Aug 13, 2023
@Scraticus Scraticus added Type: Upstream Bug Bug inherited from upstream Status: Solved! This one is done! and removed Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase labels Aug 13, 2023
@Scraticus
Copy link
Member

A workaround fix will be added in a17 of 042, but will be fixed in the main release of Alpha V 042.

Thanks for reporting guys

@Scraticus Scraticus changed the title [Unexpected Behavior] Lyrics do not scroll at the correct speed when Rate is adjusted [FIXED] [BUG]Lyrics do not scroll at the correct speed when Rate is adjusted Aug 13, 2023
@Scraticus
Copy link
Member

fixed in 042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Driver Problem A driver or module on the operating system is not playing nice! Engine: Gameplay Gameplay Related Issues Engine: Lyrics Affects the Lyric Display Module Engine: Sound Affects sound, sync, playback, music etc Status: Solved! This one is done! Type: Bug Something is broken in the code Type: Upstream Bug Bug inherited from upstream
Projects
None yet
Development

No branches or pull requests

4 participants