Ignore stable coins

[saschb2b]

Is your feature request related to a problem? Please describe.
Buying a stable coins means it will just "move" the money and probably won't generate any noticeable profit

Describe the solution you'd like
An config options to ignore stable coins from the buying decisions completely

Additional context
Default should be false to don't break existing configs. Open question would be on how to actually detect which is a "stable" coin and which not

[engAhmad]

stable coins should be blacklisted , i think adding them to local storage or pulling from trusted source then avoid them from trading will be good move ,
the big problem is no identifier for them also some coins maybe not presented as a stable coins but behave as a stable coins , right now am just hard coding like this
"blacklist": [ "DASH", "GRIN", "XMR", "ZEC", "DAI", "SDT", "CUSD", "USDC", "BUSD", "RSR", "HUSD", "TUSD", "PAX", "GUSD", "QC", "KRT", "EURS", "USDK", "USDN", "ANCT", "EUSD", "USNBT", "CONST", "BITCNY", "EBASE", "IDRT", "EOSDT", "BITUSD", "WSD", "BGBP", "USDS", "USDX", "BITEUR", "XEUR", "1SG", "NIRX", "USDQ", "VNDC", "XAUT", "USC", "SDUSD" ],

[saschb2b]

I've started a PR regarding this. Any feedback is valuable. Will extend it with some of your blacklisted coins #36

[engAhmad]

https://en.cryptonomist.ch/stablecoins-list/

this was my source maybe some of them not listed on bittrex i will double check and keep you updated

[saschb2b]

Great source! I've nearly added all of them. The first ones seem more of your "normal" blacklisted ones instead of stable coins.

It also doesn't matter if bittrex doesn't have them, yet. We are future proof then.

[engAhmad]

"DASH", "GRIN", "XMR", "ZEC", was in the array for blacklist by default also i hate them :)

i found these on bittrex for sure
"coins": [ "CUSD", "DAI", "PAX", "SBD", "TUSD", "USDC", "USDN", "USDS", "USDT", "UST", "SDT", "KRT" ]

[saschb2b]

I said "default should be false". But the more I think about it true would be a better default.
Sure, it will limit users in the next release without changing the config, but for good.
Stablecoins should not be traded with this bot as the invest stays just there without generating any profit.

If someone is against it just comment. Otherwise I'll merge the PR over the weekend

[saschb2b]

I think I don't understand it correctly. Can you elaborate it further?
With the current approach the bot will ignore all listed stablecoins in the evaluation phase (no automated buying/selling based on ema will happen).

[engAhmad]

The problem for buying stable-coins right now sorted ,Thank you

[saschb2b]

We should also ignore them in the revenue sell phase right?
Otherwise your e.g. 120$ worth of manually bought DAI would partly be sold because "you are over your e.g. 50$ invest"

[engAhmad]

That is right " should also ignore them in the revenue" .

now i'm digging with basic stuff like node-v , yarn-v
notes performance problem it takes 525448.93998 ms to finish

[13:52:42] ########## Started ichimoku ##########
[13:52:58] PHNX placed REVENUE SELL order for 3.8155401144375 USDT
[13:53:02] TRAC placed REVENUE SELL order for 5.809712948194001 USDT
[13:53:08] XUC placed REVENUE SELL order for 0.1263410288685094 USDT
[13:53:12] Collected revenue 29573.11072 ms
[13:53:12] Fetched 705 and filtered 151 USDT markets 28.03293 ms
[13:53:12] Fetched 705 and filtered 151 market summaries 38.86732 ms
[14:01:28] Evaluated 151 markets in total 495799.02544 ms
[14:01:28] ########## Finished 525448.93998 ms ##########

also it stopped selling or buying new coins after adding the stable-coins to backlist array in the config file

{ "HODL": [ "BTC", "ETH" ], "amountPerInvest": 20.0, "blacklist": [ "DASH", "GRIN", "XMR", "ZEC", "CUSD", "DAI", "PAX", "SBD", "TUSD", "USDC", "USDN", "USDS", "UST", "SDT", "KRT", "UPUSD" ], "debug": false, "exactPositiveTicks": 2, "enableReporting": false, "ignoreTokenizedStocks": true, "mainMarket": "USDT", "minNegativeTicks": 2, "refreshTimeout": 180000, "tickInterval": "DAY_1", "emaConfiguration": { "default": { "s": 9, "l": 26 } } }

[saschb2b]

Performance:
This comes due to the limitation of the bittrex api. It only allows ~60requests per minute. So we have some manual wait time between requests to not get blocked.
Sadly this results in the long total amount. We could see which requests we can omit to speed things up. But for now I don't know which.

Stopping buying new coins:
Maybe there isn't any viable option for buying currently? Adding those shouldn't general break the evaluation of other options.
I'll improve the logging to reflect this behavior. Would you mind opening an issue for that?