Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Placeholder is not displayed entirely when fullWidth is enabled #200

Closed
ugomeda opened this issue Apr 26, 2018 · 5 comments
Closed

Placeholder is not displayed entirely when fullWidth is enabled #200

ugomeda opened this issue Apr 26, 2018 · 5 comments
Labels

Comments

@ugomeda
Copy link

ugomeda commented Apr 26, 2018

In version 1.0.0-beta4, with this code :

<ChipInput
  fullWidth
  placeholder="Ajouter des utilisateurs au groupe"
/>

The placeholder is cut :

screenshot from 2018-04-26 10-27-42

@leMaik
Copy link
Member

leMaik commented Apr 30, 2018

This is due to us using the placeholder of the input element (which doesn't fill the entire width by design). We'll have to see how we can fix this.

@fabriziocucci
Copy link

Is there a temporary workaround for this?

@leMaik
Copy link
Member

leMaik commented Sep 22, 2018

@fabriziocucci No, but I'd appreciate a PR that permanently fixes this. 👍

@trylimits
Copy link

It seems like that this issue does not only affect the placeholder, but long inputs in general.
The following workaround fixes both issues this for me:

const styles = theme => ({
    chipContainer: {
        display: 'flex',
        flexFlow: 'row wrap'
    },
    inputRoot: {
        flex: '1 0 auto'
    }
});

[...]

<ChipInput
  classes={{
    chipContainer : classes.chipContainer,
    inputRoot : classes.inputRoot
  }}
  fullWidth
/>

@leMaik
Copy link
Member

leMaik commented Jan 20, 2019

@trylimits Thank you! Somehow, this wen't completly off my radar. I just added that fix and I'll credit you in the changelog. 👍

@leMaik leMaik closed this as completed in d47cc25 Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants