-
-
Notifications
You must be signed in to change notification settings - Fork 210
Support for start and end adornments #248
Comments
Indeed, it would be great if this worked! 😮 @abilash13 If you want to give it a try, this looks like a styling issue. The |
Is there any particular reason that most of the styling on the chip input is done with display: inline-block and margins instead of flex-box? Material-ui inputs are done with flex-box from what I am seeing. I am working on a project where I need this and due to time constraints am going to fix it inline. If there aren't already discussed reasons against flex-box I can make a pull request with my changes in order to get start adornments working and in the correct location |
@me245 No specific reason, might be some artifacts from the port from v0 to v1. Please feel free to change that, I'd be happy to see a PR.
Sounds great! 👍 Please just make sure that nothing else breaks (i.e. look into the storybook, check the tests). |
@me245 Any updates on this? |
I have a working solution for filled and outline inputs. I can make the changes for the default input too, just had a time constraint. As I am doing the default input, I am noticing a fair amount of duplicated css code that I am not liking. As I know other people are interested in this feature I can get that PR in, but I would want another issue put in to do some refactoring to use InputBase. I could use #244 as the issue to refactor, as that would be the fix for the issue that I am seeing |
@me245 Sounds good, you can do both in a single PR, if you want. 👍 |
I was trying it like this:
Which is the standard way of doing it with material-ui |
Any progress on this? Would be great if it worked? |
Any progress on this issue? Why the PR is not merged still? |
any update? |
Yeah, use this instead: https://material-ui.com/components/chips/ |
Right now, if we add a startAdornment and endAdornment to the InputProps, it looks and acts strange.
For example, this is how it looks for an empty chip input with start and end adornments:
![screenshot 2018-11-27 at 2 11 21 pm](https://user-images.githubusercontent.com/5894226/49069221-b736e880-f24e-11e8-8ec5-d63a62a28579.png)
This is how I need it to look:
![screenshot 2018-11-27 at 2 11 31 pm](https://user-images.githubusercontent.com/5894226/49069247-ccac1280-f24e-11e8-837b-33e1c712af20.png)
And when a new chip is added, this is how it looks:
![screenshot 2018-11-27 at 2 11 42 pm](https://user-images.githubusercontent.com/5894226/49069277-e2b9d300-f24e-11e8-9009-4f4669ce8171.png)
This is how I need it to look:
![screenshot 2018-11-27 at 2 16 39 pm](https://user-images.githubusercontent.com/5894226/49069366-1e549d00-f24f-11e8-851f-eb3db9036119.png)
Any idea if I can get this behavior by tweaking something?
The text was updated successfully, but these errors were encountered: