Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In material-ui 0.19.0 onTouchTap has been removed. #8

Closed
KrzysztofKarol opened this issue Aug 28, 2017 · 0 comments
Closed

In material-ui 0.19.0 onTouchTap has been removed. #8

KrzysztofKarol opened this issue Aug 28, 2017 · 0 comments

Comments

@KrzysztofKarol
Copy link
Contributor

The react-tap-event-plugin dependency was removed. This change is paving the way toward supporting the upcoming react@16 release a.k.a Fiber. The react-tap-event-plugin dependency was first introduced 3 years ago in order to remove the click delay on mobile devices. Mobiles devices' browsers have improved since then, it's no longer required. It's time to remove that dependency as we have done it a year ago on the v1-beta branch. You need to replace the onTouchTap property callbacks with onClick.

https://github.com/callemall/material-ui/blob/v0.19.0/CHANGELOG.md

I follow the CHANGELOG tip and material-ui-fullscreen-dialog is working now.
I'm preparing PR. It'll be ready in 30 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant