Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting start path to Update.exe does not work #59

Open
marcindanek85 opened this issue Apr 28, 2017 · 2 comments
Open

Setting start path to Update.exe does not work #59

marcindanek85 opened this issue Apr 28, 2017 · 2 comments
Assignees

Comments

@marcindanek85
Copy link

marcindanek85 commented Apr 28, 2017

  • The target platform(s) the problem occurs on (Linux, Mac, Mac App Store, and or Windows): Windows 8.1

  • Node version (run node -v): 6.3.0

  • auto-launch version: 5.0.1

  • The options you're passing to auto-launch: var AutoLaunch = require("auto-launch");

    var appLauncher = new AutoLaunch({
    name: "Trampoline"
    });

  • Are you using NW.js or Electron? Electron

    • If so, which version? "1.6.6"
    • If you're using Electron, are you using auto-launch from the main process or a renderer process? main process
  • Can you reproduce this with a simple Hello World example app? haven't tried yet

  • If needs be, would you be able to provide us with a simple app (as simple as possible) which reproduces the problem? will prepare one


The issue is, that calling appLauncher.enable() creates registry entry pointing to executable path. It documentation there is info, that squirrel should be detected and path to Update.exe should be set. Is it true? What should I set, that auto-launch detect squirrel?

Additionaly, if I set name and path (calculated path do the Update.exe --processStart trampoline.exe) i get such entry in registry: Update.exe --processStart trampoline, but the name is set to Trampoline... It seems to be ignored and taken from appPath with removing ending .exe...

EDIT: it cannot work, as paths are set in fixOpts function, that sets for windows invalid path and entry name.

@adam-lynch
Copy link
Contributor

Right now, auto-launch doesn't support passing additional arguments. The work to support this has been started on #47.

But, I don't think we do anything special our Teamwork Chat Windows desktop app (which updates via Squirrel). Right @4ver?

@marcindanek85
Copy link
Author

I've reviewed the source code of the auto-launch a few weeks ago, and all this code was implemented, but was overwritten on some level, and all the logic, that is specific to Windows, was lost. I've rewritten it quickly in typescript. If you are interesed - I can share the source code with You.

@Oxalin Oxalin self-assigned this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants