New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fraweworks don't follow the rules #6788
Comments
In the cached queries some fw are caching the response. later we continue !!! Tests: ;) |
https://github.com/vasily-kartashov you are the first |
In this test, each request is processed by fetching multiple cached objects from an in-memory database (the cache having been populated from a database table either as needed or prior to testing) and serializing these objects as a JSON response. The test is run multiple times: testing 1, 5, 10, 15, and 20 cached object fetches per request. All tests are run at 512 concurrency. Conceptually, this is similar to the multiple-queries test except that it uses a caching layer. |
NOT a cached response |
Thanks @joanhey I’m returning to the office in a couple of weeks and I’ll take a look at this. |
Seems "just" framework uses const message object for json bench. I am not sure, I don't have much of js knowledge.
|
i think you are right @fafhrd91. i cannot remember why i did it this way but that certainly wasn't intentional. i will create a PR just to use JSON.stringify on a new object. |
@billywhizz just still uses const message @nbrady-techempower |
I would not presume malicious intent, given that the author has been responsive to issues like that in the past. Anyway, apparently there is already a fix. |
Check the multiple queries for Redkale It's the first and twice faster than the next fw, and in single query have about 40 faster in front. |
Redkale seems to be using an entity cache. The single and multiple queries benchmark rules don't permit this "Use of an in-memory cache of World objects or rows by the application is not permitted." (see rule xii of https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#single-database-query) For the single query scenario And the relevant callee of This is likely also the source of the updates score discrepancy (given that it also calls into @redkale could you verify whether this is the case? |
As already discussed in #7899 and #7900, it appears that requirement 7b of the cached queries test is frequently violated:
In particular, the following implementations seem not to comply:
Note that this list is definitely not exhaustive. Pinging @abahmed, @chrislearn, @Fenny, @fundon, @redkale, and @savsgio for their input. |
@volyrique |
@NinoFloris |
OS (Please include kernel version)
Expected Behavior
Actual Behavior
Steps to reproduce behavior
Other details and logs
The text was updated successfully, but these errors were encountered: