Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nature restore not working #1309

Closed
6 tasks
FlyingMarkus opened this issue Mar 13, 2021 · 2 comments · Fixed by #1448
Closed
6 tasks

Nature restore not working #1309

FlyingMarkus opened this issue Mar 13, 2021 · 2 comments · Fixed by #1448
Labels
🐛Bug Issue is a validated bug report.

Comments

@FlyingMarkus
Copy link

What happened:

A player has not used his claim for 14 days (test setting). The protection has been removed. The automatic restoration of nature only worked superficially. Deeper blocks (mine) were not removed. Individual torches are also still visible. Nature is not restored, only what has been built is erased. Why is that?

What was expected:

Nature should be restored to the way it was before the player removed or replaced blocks

Steps to reproduce:

Here is a Screenshot: https://abload.de/img/2021-03-13_10.11.38uak9g.png

Server and GriefPrevention version:

This can be found by running /version and /version GriefPrevention on your server.
Paste of /version: https://abload.de/img/serverversiolajem.png
Paste of /version GriefPrevention: 16.16.0

Stack trace/error or server log

Paste entire stack trace right here inside these backticks.

Or, paste the server.log at gist.github.com and paste the link here:

GriefPrevention config.yml

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/
GriefPrevention:
  SeaLevelOverrides:
    emazinworld: -1
    emazinworld_nether: -1
    emazinworld_the_end: -1
    newbeespawn: -1
    IridiumSkyblock_nether: -1
    farm: -1
    IridiumSkyblock: -1
    grundstueck: -1
  Claims:
    Mode:
      IridiumSkyblock: Disabled
      grundstueck: Disabled
      emazinworld_nether: Disabled
      farm: Disabled
      emazinworld_the_end: Disabled
      newbeespawn: Disabled
      emazinworld: SurvivalRequiringClaims
      IridiumSkyblock_nether: Disabled
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: false
    LockTrapDoors: false
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 200
    Claim Blocks Accrued Per Hour:
      Default: 100
    Max Accrued Claim Blocks:
      Default: 100000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 30
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 265
    MinimumWidth: 5
    MinimumArea: 30
    MaximumDepth: 0
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 182
      UnusedClaimDays: 182
      AllClaims:
        DaysInactive: 182
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: true
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 5
    CreationRequiresWorldGuardBuildPermission: false
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: true
    LoginCooldownSeconds: 10
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: true
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      emazinworld: false
      emazinworld_nether: false
      emazinworld_the_end: false
      newbeespawn: false
      IridiumSkyblock_nether: false
      farm: false
      IridiumSkyblock: false
      grundstueck: false
    ProtectFreshSpawns: true
    PunishLogout: true
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksMaxBonus: 100000
    ClaimBlocksPurchaseCost: 7.0
    ClaimBlocksSellValue: 7.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: false
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  PistonMovement: CLAIMS_ONLY
  PistonExplosionSound: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 3
  Siege:
    Worlds: []
    BreakableBlocks:
    - GRASS_BLOCK
    - DIRT
    - COBBLESTONE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - SAND
    - GRAVEL
    - GLASS
    - GRASS
    - FERN
    - DEAD_BUSH
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    - GLASS_PANE
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false

Plugin list (if applicable): https://abload.de/img/plugins3tj7i.png

Debugging steps attempted

  • I attempted running only GriefPrevention on the server
    • Issue still occurs even if GriefPrevention is the only plugin running
  • I attempted testing for the issue on a new server
    • Issue still occurs even after testing on a new server
  • I attempted testing for the issue with the vanilla client (no mods)
    • Issue still occurs even after testing with the vanilla Minecraft client
@Jikoo
Copy link
Collaborator

Jikoo commented Mar 15, 2021

Image linking those so GH plops them in camo - I personally don't click most links.
image
version
plugins

Looks like we're missing some materials from player blocks - polished stone and wall torches. The planks should definitely be removed though. Have you got any datapacks in place that are modifying vanilla tags?

Re: mines: when a claim is restored, only the blocks inside the claim are affected. Things like mineshafts underneath the claim do not get restored unless the claim extends down to cover them. Even if they did get "restored" you wouldn't see ore come back - see the following section.

Re: deleting blocks vs fully natural landscape: GP doesn't go for a full regeneration approach like WorldEdit's //regen, it makes a best effort to remove obvious player touches. There've been suggestions to make that an option, but that would probably be outsourced to an addon.

@Jikoo
Copy link
Collaborator

Jikoo commented Mar 15, 2021

Going to label this a bug because I can confirm we're missing material WALL_TORCH (and probably SOUL_TORCH/SOUL_WALL_TORCH while we're at it) but not going to remove unverified because I haven't checked the rest.

@Jikoo Jikoo added the 🐛Bug Issue is a validated bug report. label Mar 15, 2021
@Jikoo Jikoo mentioned this issue Jul 8, 2021
RoboMWM pushed a commit that referenced this issue Jul 10, 2021
* Update to include 1.17 materials and tags

* Use world height for claim max height

* Account for worlds with min height < 0

Fix restore not working under y 0
Change default max claim depth to integer min value
Fix creative claims always going to 0, not world min height

* Update material listings to include new blocks
  * Fixes a few missed cases from previous versions
* Replaced claim to bounding box bandaid for world max height increase with actual world limit
* Account for worlds with min height less than zero
  * New default maximum depth is now integer min value (-2147483648) to not restrict users no matter how weirdly they set up worlds
  * Creative claims always extend to world min height, not 0
  * RestoreNature restores to a max depth of world min height instead of 0

Closes #1309 
Closes #1431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Issue is a validated bug report.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants