Glow berries can be placed and broken in a claim, with only containertrust

[snurre0]

What happened:

Glow berries can be placed and broken inside a claim, with only containertrust.

What was expected:

Placing and breaking glow berries should require full trust, not only containertrust.

Steps to reproduce:

1. Player one creates a claim, and adds containertrust to player two.
2. Player one places glow berries inside the claim.
3. Player two breaks and places glow berries inside the claim.

Server and GriefPrevention version:

Paste of /version: This server is running Paper version git-Paper-239 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: ca708a0)
Paste of /version GriefPrevention: GriefPrevention version 85b76cc

Stack trace/error or server log

I have not included server log, as I don't want to expose the entire chat log here. If it's still needed, I'll see what I can do.

GriefPrevention config.yml

GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
  Claims:
    Mode:
      world: Survival
      world_the_end: Survival
      world_nether: Survival
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 225
    Claim Blocks Accrued Per Hour:
      Default: 150
    Max Accrued Claim Blocks:
      Default: 300000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 20
    MinimumWidth: 1
    MinimumArea: 10
    MaximumDepth: 0
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 9999999
      UnusedClaimDays: 9999999
      AllClaims:
        DaysInactive: 9999999
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: true
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local;/minecraft:me;/tpa;/suicide
    WhisperSlashCommands: ''
    WarningMessage: Please reduce your noise level.  Spammers will be muted.
    BanOffenders: false
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 60
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: true
      world_nether: true
      world_the_end: true
    ProtectFreshSpawns: true
    PunishLogout: false
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: true
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: false
      AdministrativeClaims: false
      AdministrativeSubdivisions: false
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: false
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: false
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: true
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: true
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: false
  BlockSurfaceOtherExplosions: false
  LimitSkyTrees: false
  LimitTreeGrowth: false
  PistonMovement: EVERYWHERE
  PistonExplosionSound: true
  FireSpreads: true
  FireDestroys: true
  AdminsGetWhispers: false
  AdminsGetSignNotifications: true
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 5
  SilenceBans: true
  Siege:
    Worlds: []
    BreakableBlocks:
    - DIRT
    - GRASS
    - LONG_GRASS     <-- can't understand this entry, see BukkitDev documentation
    - COBBLESTONE
    - GRAVEL
    - SAND
    - GLASS
    - THIN_GLASS     <-- can't understand this entry, see BukkitDev documentation
    - WOOD     <-- can't understand this entry, see BukkitDev documentation
    - WOOL     <-- can't understand this entry, see BukkitDev documentation
    - SNOW
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: true
  SilverfishBreakBlocks: true
  CreaturesTrampleCrops: true
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: true
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: false
      Administrative Activity: true
      Debug: false
      Muted Chat Messages: true

Plugin list (if applicable):

AntiXRay, AutoMessage, BuycraftX, Chunky, CommandHook, EntityWatch, Essentials, EssentialsChat, EssentialsDiscord, EssentialsSpawn, F3NPerm, GriefPrevention, HolographicDisplays, InteractiveBooks, InventoryRollback, LogBlock, LuckPerms, Matrix, OpenInv, PlugMan, ProtocolLib, Reports, Vault, VoteRoulette, Votifier, WorldEdit, WorldGuard

Debugging steps attempted

• (If applicable) I attempted running the server without GriefPrevention installed
  • (If applicable) The problem does not occur if GriefPrevention is removed from the server.
• I attempted running only GriefPrevention on the server
  • Issue still occurs even if GriefPrevention is the only plugin running
• I attempted testing for the issue on a new server
  • Issue still occurs even after testing on a new server
• I attempted testing for the issue with the vanilla client (no mods)
  • Issue still occurs even after testing with the vanilla Minecraft client

[Jikoo]

These are specifically treated as a farmable resource. Probably better being a discussion, but I'm just gonna apply the tag for now instead of converting.

[snurre0]

For the farming part in #1564, I agree with you. But for actual breaking of the vines you get from planting glow berries, and placing new vines, I still think this should be protected even if you have containertrust, and still be considered a bug.
Giving players access to your containers should not let them break decorative or farmable blocks, or place them all over the claim, in my opinion.

Why would you be able to break this specific farmable resource with container trust, where you would not be able to with other farmable resources?

[Jikoo]

You can break other farmable resources. Wheat, carrots, etc. all are fully breakable because that's just how they work. GP doesn't really have a concept of "farmable but not breakable" although that might be a good enhancement.

[snurre0]

Right, okay. So this new item/block just happen to have a way to be farmed without breaking it, which GriefPrevention have no way to handle(for now at least).

I don't know how the code and handles in Minecraft/java works, so I have no idea if it's even possible to handle it the way I think it should be handled.

[Jikoo]

It is possible, it's just that GP handles this and similar existing blocks the same way, namely, if you're allowed container access you'd be able to bust other crops, so you should have consistent permission to bust these as they are also farmable crops.

I do agree that it would be handy, particularly for these and sweet berries as those damage players. While I'm pretty sure grass floors in a shop are quite uncommon, not leaving players vulnerable to death by berries while afk in a communal area would be nice.

[snurre0]

Thanks for the explanation. This will be more of an enhancement request then I guess.

(I've seen a few shops with grass floor on our server over the years, but not too many :p )

[RoboMWM]

yes this should be a discussion, as I see no bug to fix here.