Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClaimInspectionEvent #946

Merged
merged 1 commit into from Aug 7, 2020
Merged

Add ClaimInspectionEvent #946

merged 1 commit into from Aug 7, 2020

Conversation

FrankHeijden
Copy link

Since GP is listening on the LOWEST event priority for claim inspections, this will add a way to cancel these inspection events.

bigpresh
bigpresh previously approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@bigpresh bigpresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a slight dislike of the name of shiftInspecting, I like this - it'll allow plugins to replace GP's own claim visualisations neatly, or do additional things when a claim is visualised.

src/main/java/me/ryanhamshire/GriefPrevention/events/ClaimInspectionEvent.java Outdated Show resolved Hide resolved
bigpresh
bigpresh previously approved these changes Aug 7, 2020
View reviewed changes
@FrankHeijden FrankHeijden dismissed stale reviews from RoboMWM and bigpresh via 76ade09 August 7, 2020 15:32
@RoboMWM RoboMWM merged commit 2d3c3a3 into GriefPrevention:master Aug 7, 2020
@FrankHeijden FrankHeijden deleted the feature/claim-inspection-event branch August 7, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoboMWM RoboMWM RoboMWM approved these changes

@bigpresh bigpresh bigpresh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrankHeijden @bigpresh @RoboMWM