New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve overlap check #999

Merged

RoboMWM merged 1 commit into GriefPrevention:master from Jikoo:dev/rectangles

Sep 7, 2020

Collaborator

Jikoo commented Sep 5, 2020

Due to a mistake in the previous check (self instead of other used for comparison) claims could not be created north of existing claims.

The unit test changes included now properly catch this, failing when run on 70b6574


          Improve overlap test and fix mistake

c039f86

RoboMWM approved these changes

View reviewed changes

RoboMWM merged commit 39e9d48 into GriefPrevention:master

RoboMWM commented Sep 7, 2020

hooray, the last 3-digit issue was a PR.

Jikoo deleted the dev/rectangles branch

September 7, 2020 11:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment