Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Location review: struct design #265

Closed
chananbental opened this issue Apr 15, 2018 · 4 comments
Closed

Design: Location review: struct design #265

chananbental opened this issue Apr 15, 2018 · 4 comments

Comments

@chananbental
Copy link
Collaborator

No description provided.

@chananbental chananbental self-assigned this Apr 15, 2018
@chananbental chananbental added this to Backlog in Roommates via automation Apr 15, 2018
@chananbental chananbental added this to the Mid Semester POC milestone Apr 15, 2018
@chananbental
Copy link
Collaborator Author

{
id: obectID,
street name: string,
city: string,
rated characteristics:
{
parking: real,
publicTransport: real,
noise: real,
commercialServices: real,
upkeep: real,
general rating: real
},
voters: [objectID, objectID],
usersRevies: [
{
_createdBy: ObjectID,
review: string
}
]
}

Roommates automation moved this from Backlog to Done Apr 15, 2018
@OrAbramovich
Copy link
Collaborator

OrAbramovich commented Apr 15, 2018

Hi @chananbental ,
I think you should consider to add geo-location data (longtitude and latitude) since:

  1. We will be able to give a review for the area (e.g. of 500 meters).
  2. It's a normal form: user might type "מלל" and the other one "מל"ל" etc.
  3. We will be able to add an efficient DB index.

@chananbental
Copy link
Collaborator Author

good point @OrAbramovich , thanks
ill update in the document i am writing, ill add a link when i finish

@chananbental chananbental reopened this Apr 15, 2018
Roommates automation moved this from Done to Backlog Apr 15, 2018
@chananbental
Copy link
Collaborator Author

locatin review API

Roommates automation moved this from Backlog to Done Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roommates
  
Done
Development

No branches or pull requests

2 participants