Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackEnd: add route: PUT /reviews/:id #275

Closed
chananbental opened this issue Apr 16, 2018 · 6 comments
Closed

BackEnd: add route: PUT /reviews/:id #275

chananbental opened this issue Apr 16, 2018 · 6 comments
Assignees
@chananbental
Labels
Back-End
Projects
Roommates
Milestone
Mid Semester POC

Comments

@chananbental
Copy link
Collaborator

No description provided.

@chananbental chananbental added this to the Mid Semester POC milestone Apr 16, 2018
@chananbental chananbental self-assigned this Apr 16, 2018
@chananbental chananbental added this to Backlog in Roommates via automation Apr 16, 2018
@alonttal
Copy link
Collaborator

alonttal commented Apr 16, 2018 •
edited

hi Chanan:
"PUT /reviews/:id" is enough
the request body will contain all the data

@chananbental
Copy link
Collaborator Author

ok

@chananbental chananbental changed the title BackEnd: add route: PUT /review/city/street/userID BackEnd: add route: PUT /review/:id Apr 16, 2018
@chananbental chananbental changed the title BackEnd: add route: PUT /review/:id BackEnd: add route: PUT /reviews/:id Apr 16, 2018
@chananbental
Copy link
Collaborator Author

are you sure?
who's id is in the route?
the way it works is that each street has an entry in the database with its reviews.
therefore when i want to add a new review i look for the street using the city and street
so why would it not be reviews/:city/:street?

@OrAbramovich
Copy link
Collaborator

@chananbental , before you start with the routes please create tests for the reviews model and make sure they pass. It seems that there are bugs there.

@chananbental
Copy link
Collaborator Author

ill get right on it

@chananbental chananbental moved this from Backlog to In progress in Roommates Apr 17, 2018
@chananbental chananbental moved this from In progress to Tasks for this week in Roommates Apr 17, 2018
@chananbental
Copy link
Collaborator Author

this issue is irelevent because of the design change
now that we save each review by its self and not for each road this route means nothing

Roommates automation moved this from Tasks for this week to Done Apr 23, 2018
@chananbental chananbental mentioned this issue Apr 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chananbental chananbental

Labels
Back-End
Projects
Roommates
  
Done
Milestone
Mid Semester POC
Development

No branches or pull requests
3 participants
@OrAbramovich @alonttal @chananbental