Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apartment page: enable notifications #593

Closed
omrihuller opened this issue Jun 18, 2018 · 3 comments
Closed

Apartment page: enable notifications #593

omrihuller opened this issue Jun 18, 2018 · 3 comments
Assignees
@OrAbramovich @omrihuller
Labels
Front-End
Projects
Roommates
Milestone
End of Semester Demo

Comments

@omrihuller
Copy link
Collaborator

nothing happens when trying to toggle this button (at least in the front end)

if it exists in the back end we need to connect it.
@omrihuller omrihuller added this to the End of Semester Demo milestone Jun 18, 2018
@omrihuller omrihuller added this to Backlog in Roommates via automation Jun 18, 2018
This was referenced Jun 18, 2018
Closed
Open
@OrAbramovich OrAbramovich self-assigned this Jun 19, 2018
@OrAbramovich
Copy link
Collaborator

OrAbramovich commented Jun 19, 2018 •
edited
Loading

Hi @omrihuller ,
It was a dummy slider (wan't connected to the back-end).
I have just connected it to the back-end and it should work.
See commit 004ec87

@OrAbramovich OrAbramovich mentioned this issue Jun 19, 2018
Open
@OrAbramovich
Copy link
Collaborator

@omrihuller ,
It would be great if you could update the Master and verify it. Once verified - you can close it.
BTW, the slider is available in the apartment page and was removed from the apartment ad in the main page.

OrAbramovich referenced this issue Jun 19, 2018
@OrAbramovich
Front-end: Activate option to subscribe to apartment page
004ec87 
Front-end: Remove "enable notifications" from profile component and add it to apartment page.

Removed the "enable notifications" from profile component and added it to apartment page + integration with the back-end so it actually works.

#599, #600
@omrihuller
Copy link
Collaborator Author

Works as intended, notifications are enabled on apartments you post by default and you can change at any time

closed

Roommates automation moved this from Backlog to Done Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrAbramovich OrAbramovich

@omrihuller omrihuller

Labels
Front-End
Projects
Roommates
  
Done
Milestone
End of Semester Demo
Development

No branches or pull requests
2 participants
@OrAbramovich @omrihuller