Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe readme typo errors? #2

Closed
Pistacchione opened this issue Dec 2, 2020 · 2 comments
Closed

Maybe readme typo errors? #2

Pistacchione opened this issue Dec 2, 2020 · 2 comments

Comments

@Pistacchione
Copy link

Hi,

in the readme file there is this example:

Container(
      width: 20.0.w,    //It will take a 20% of screen width
      height:30.0.h     //It will take a 20% of screen height
    )

maybe there is a typo error and comment for height: 30.0.h should be It will take a 30% of screen height?

Another question,
TextStyle(fontSize: 15.0.sp), 15.0.sp is always a percentile of screen width or height?

Thanks!

@TechnoUrmish
Copy link
Owner

Hi,

in the readme file there is this example:

Container(
      width: 20.0.w,    //It will take a 20% of screen width
      height:30.0.h     //It will take a 20% of screen height
    )

maybe there is a typo error and comment for height: 30.0.h should be It will take a 30% of screen height?

Another question,
TextStyle(fontSize: 15.0.sp), 15.0.sp is always a percentile of screen width or height?

Thanks!

Thank you Matteo Benin for find issue in my package and yes it is typo error in readme file and .sp method working always a percentile of screen size

@Pistacchione
Copy link
Author

Great,

Thank you for this very useful package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants