Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

AWS dimension select config issue #9

Open
tul opened this issue Oct 1, 2018 · 0 comments
Open

AWS dimension select config issue #9

tul opened this issue Oct 1, 2018 · 0 comments

Comments

@tul
Copy link

tul commented Oct 1, 2018

Something that might be worth making clear in the documentation: the aws dimension select in this tool is called aws_dimensions_select_regex in the config file, whereas in the official Java tool, it's called aws_dimension_select_regex (ie without the "s").

This had me scratching my head for a while when moving a config over from the official exporter to this one.

Also, the aws_dimensions_select_regex in this tool only supports 1 regexp per dimension, whereas the official one supports a list. It might be worth considering adding support for a list of reg exps as a new key called aws_dimension_select_regex and then it would be compatible with the official tool in both key name and format?

You could leave the existing aws_dimensions_select_regex supporting a single regexp for backwards compatibility perhaps.

@ghost ghost added the enhancement label Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant