Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a CI workflow for coverage measurement #5

Closed
Technologicat opened this issue Oct 17, 2020 · 2 comments
Closed

Set up a CI workflow for coverage measurement #5

Technologicat opened this issue Oct 17, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Technologicat
Copy link
Owner

Technologicat commented Oct 17, 2020

Make tests run on 3.6, 3.7, 3.8 and PyPy3. Measure coverage, too.

unpythonic has suitably customized workflows that can be quickly adapted to this.

Also grab its flake8rc, and maybe tune it to remove some idiosyncracies.

Also try black; but may be it doesn't make sense on this codebase. A macro expander is almost as far from a regular Python project as language extensions such as unpythonic are. Having blank lines serve as logical paragraph breaks is valuable. Some of the PEP8 rules occasionally hinder that, causing blank lines (or double-blank-lines) to no longer map 1:1 to breaks between logical units. PEP8 is great as long as it improves readability, but foolish consistency and all that.

Depends on #2.

@Technologicat Technologicat added the enhancement New feature or request label Oct 17, 2020
@Technologicat Technologicat added this to the 3.0.0 milestone Oct 17, 2020
@Technologicat Technologicat modified the milestones: 3.0.0, 3.1.0 Nov 12, 2020
@Technologicat Technologicat modified the milestones: 3.1.0, 3.2.0 Feb 11, 2021
@Technologicat Technologicat modified the milestones: 3.2.0, 3.3.0 Apr 7, 2021
@Technologicat
Copy link
Owner Author

Technologicat commented May 8, 2021

As of 853d1bf, CI enabled for running automated tests. We don't have many yet, but it's a start - and at least they now run automatically on all supported Python versions.

The flake8rc and pylintrc I'm using for linting during development are already in the repo.

We still need to set up codecov, like unpythonic has, and then add the badges to the README (see #7).

Steering away from black for now.

@Technologicat Technologicat changed the title Set up a CI workflow for testing Set up a CI workflow for coverage measurement May 8, 2021
@Technologicat
Copy link
Owner Author

As of e5a678b, CI enabled for coverage measurement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant