Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: use ssh agent forwarding #15

Open
yelizariev opened this issue Mar 26, 2020 · 2 comments
Open

Development: use ssh agent forwarding #15

yelizariev opened this issue Mar 26, 2020 · 2 comments
Labels
hacktoberfest Good for newcomers

Comments

@yelizariev
Copy link
Contributor

This is a lifeboat for Tecnativa/doodba-scaffolding#72

Before I make a pull request for copier template, @yajo could you tell me your general view of the issue and solution

@yajo
Copy link
Contributor

yajo commented Mar 26, 2020

Well, as you can see now we have a better infrastructure to handle that.

IMHO that logic should go into

@task(develop)
def git_aggregate(c):
"""Download odoo & addons git code.
Executes git-aggregator from within the doodba container.
"""
c.run(
"docker-compose --file setup-devel.yaml run --rm odoo",
env={"GID": os.getgid(), "UID": os.getuid(), "UMASK": 27},
)
_write_code_workspace_file()
for pre_commit_folder in iglob(
str(SRC_PATH / "*" / ".git" / ".." / ".pre-commit-config.yaml" / ".")
):
with c.cd(pre_commit_folder):
c.run("pre-commit install")
so that, if possible, we reuse host's SSH auth socket automatically.

It could be disabled by a CLI flag so that we are able to reproduce what would happen without that easily.

@yajo yajo added the hacktoberfest Good for newcomers label Sep 7, 2020
@yelizariev
Copy link
Contributor Author

I just noticed that this was also discussed in Tecnativa/doodba#292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants