Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hybrid) Mobile-View on Gmail (on Android) has margin issues #234

Closed
miamimabel opened this issue Dec 19, 2019 · 13 comments
Closed

(Hybrid) Mobile-View on Gmail (on Android) has margin issues #234

miamimabel opened this issue Dec 19, 2019 · 13 comments

Comments

@miamimabel
Copy link

Hello -

In the Hybrid template, the text margins do not line up when using the 2-column row above a 1-column row when viewing in the Gmail app on an Android. Attached is a screenshot.

I had previously reported the same issue for the Outlook mobile view, which currently looks good.

Thanks for looking into this!

hybrid-screenshot

@TedGoas
Copy link
Owner

TedGoas commented Dec 22, 2019

@miamimabel Hi, I'm unable to reproduce this exactly example, but I have a theory about what's going on. In short, when the hybrid template displays in an email client that doesn't support media queries, the layout will always stack but the margins might not line up exactly in some places.


This is what i see when I place a 1 column text after two even columns in a version of Gmail that doesn't support media queries:

Screen Shot 2019-12-22 at 11 05 04 AM

I haven't been able to reproduce this yet.

However in order to get stacking columns without media queries, it involves a clever implementation of padding, min-width, and max-width. Sometimes that leaves 30px of padding on the edges, but sometimes it leaves 20px depending on the pattern.

If this is an issue, you can try playing with the align attribute of the parent row. Eg. If something was originally aligning center, try aligning it left. You can also update the padding of various <td>s, though that will likely have an impact on the desktop layout.


Please let me know if you have any luck with the issue. I'll leave this open.

@TedGoas
Copy link
Owner

TedGoas commented Jan 8, 2020

@miamimabel Ping! Did you see my note above? up☝️

@danielbridge
Copy link

Screenshot_20200109-174228
Having the same issue with justification on many different platforms. Please help as I love this template and how easy it makes everything!

@danielbridge
Copy link

👆the responsive version

@TedGoas
Copy link
Owner

TedGoas commented Jan 10, 2020

@danielbridge Does this happen with the original source code found in this repo? If so, can you post a screenshot?

@danielbridge
Copy link

Screenshot_20200110-112351

@danielbridge
Copy link

Screenshot_20200110-112400

@danielbridge
Copy link

Screenshot_20200110-112413

@danielbridge
Copy link

This is all just the original code pasted into a blank page on WordPress and viewed on Moto z3 using chrome.

@TedGoas
Copy link
Owner

TedGoas commented Jan 10, 2020

pasted into a blank page on WordPress

I'm confused. This bug reported some odd behavior in mobile-view on Android Gmail. How does Wordpress figure in?

@danielbridge
Copy link

Its a link to the "view in as a webpage" sorry may be a separate issue and would require a separate thread. Is this code not supposed to be viewed outside of an email client? I was maybe confused by that wording as I assumed it would be able to be used as a standalone. Basically just put a link to the html doc onto my website via wordpress as a link to the "view as a webpage" text. Please help I really admire and papreciate your work as it makes complicated things easier for people like me thanks!

@TedGoas
Copy link
Owner

TedGoas commented Jan 10, 2020

Yeah I think that's a separate issue. The code can be viewed outside an email client, though I'm not sure how Wordpress (or whoever) is creating the view in as a webpage page.

@TedGoas
Copy link
Owner

TedGoas commented Nov 23, 2020

I'm still unable to reproduce the original bug reported in this issue. Closing this for now, but please reopen if you still see the issue and can provide steps to reproduce. ✌️

@TedGoas TedGoas closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants