Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outlook 2016 - fluid template - background missing #84

Closed
laughingguffly opened this issue Oct 24, 2016 · 15 comments
Closed

Outlook 2016 - fluid template - background missing #84

laughingguffly opened this issue Oct 24, 2016 · 15 comments
Assignees
@TedGoas
Labels
bug something in the original template doesn't display correctly enhancement new or improved functionality

Comments

@laughingguffly
Copy link

Firstly, great project!
I've run the source code of fluid template through putsmail and sent to outlook 2016 and the background is missing. There is also a gap at the top of the email.
@TedGoas
Copy link
Owner

TedGoas commented Oct 24, 2016

@laughingguffly can you attach a screenshot of what you see?

@laughingguffly
Copy link
Author

I've changed the images on this one, but the result is the same.

unnamed

@laughingguffly
Copy link
Author

and here is the lower half.

bottom

@TedGoas
Copy link
Owner

TedGoas commented Oct 25, 2016

@laughingguffly Hmm, I don't include background images on the Fluid template, but I do on the Hybrid one. I ran them both through Litmus and don't see the issues you describe above. If you view the latest, unedited templates in Outlook 2016, do you see something like the images below?

Fluid
ol2016-vertical-allowed-fluid

Hybrid
ol2016-vertical-allowed-hybrid

@laughingguffly
Copy link
Author

Sorry to waste your time. Fixed now and looks great in Outlook 2016.

  1. Outlook needed updating.
  2. I was using CKEditor to do the editing which was stripping the tags out from your template.

@TedGoas
Copy link
Owner

TedGoas commented Oct 25, 2016

@laughingguffly no waste at all. Thanks for doing a bit of digging on this!

@laughingguffly
Copy link
Author

laughingguffly commented Oct 25, 2016 via email

@TedGoas TedGoas self-assigned this Oct 25, 2016
@TedGoas TedGoas added bug something in the original template doesn't display correctly enhancement new or improved functionality labels Oct 25, 2016
@TedGoas
Copy link
Owner

TedGoas commented Oct 25, 2016

@laughingguffly I can reproduce the lack of background color, but not the margin. Everything looks fine when testing in Litmus or sending from Campaign Monitor, but I see this when sending from PutsMail.

Have you been able to fix this? I'll see if I can diagnose what's going on, though I don't know how much time I want to spend on this since it seems like a problem with PutsMail.

hybrid-windows10mail-vertical-allowed-1366

@TedGoas TedGoas reopened this Oct 25, 2016
@laughingguffly
Copy link
Author

Putsmail is cleansing one or more of the tags with the background color that applies to outlook 2016 by the looks of it?

Not ideal but I was able to make CKEditor turn off all stripping with the commands:
config.allowedContent = true;
config.extraAllowedContent = '()';

It would be great if I knew which tag to allow.

@laughingguffly
Copy link
Author

laughingguffly commented Oct 26, 2016 •
edited

strips out bgcolor amongst many others.

<body bgcolor="#222222" lang=EN-GB link=blue vlink=purple style='tab-interval:
36.0pt' width="100%">

@TedGoas
Copy link
Owner

TedGoas commented Oct 27, 2016

That is odd. Have you tried style: background:#222222; or style: background-color:#222222;?

@laughingguffly
Copy link
Author

Yup adding that to the body style at line 8 fixes it:

background:#222222 !important;

@TedGoas
Copy link
Owner

TedGoas commented Oct 28, 2016

That is bizarre, thanks for looking into this. I'd like to run some tests to see if this can be fixed without adding a third background color reference.

@TedGoas
Copy link
Owner

TedGoas commented Feb 23, 2017

Note to self: this is worth looking into.

@TedGoas
Copy link
Owner

TedGoas commented Apr 4, 2017

Issue seems to have resolved itself (presumably on the Putsmail side of things). Current Cerberus code, without adding an extra background:#222222 !important; to the body in <style>, seems to work in Outlook 2016 Windows.

ol2016-vertical-allowed-1366

ol2016-vertical-allowed-1366-hybrid

@TedGoas TedGoas closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedGoas TedGoas

Labels
bug something in the original template doesn't display correctly enhancement new or improved functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TedGoas @laughingguffly