Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add Domain Validation when trying to login to pterodactyl instance #50

Open
JordanPlayz158 opened this issue Dec 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@JordanPlayz158
Copy link

For reference, what is the current latest app version?

Version: 0.0.37
Build: unknown (the app's response)

Is your feature request related to a problem? Please describe.
Sort of, it is possible to misspell your domain or enter in the wrong one (which could result to leaking your api token if it is sent to the wrong domain and the app only shows unknown error on login with wrong domain so it is also not immediately obvious your domain could be wrong) so it would be nice to have some domain validation to ensure the domain is running default pterodactyl (as when you bring in custom themes, it would become virtually impossible to accurately detect a custom theme/login page, unless in the future pterodactyl introduces an anonymous pterodactyl endpoint)

Describe the solution you'd like
Find an HTML element to check for on the base URL/login page that matches the latest panel, to cover the cases of a non-standard login page or custom theme though (or if the login page UI changes dramatically or slightly that breaks your check if doesn't make logging in on old versions impossible), you can add a prompt to ask if they are sure the domain is correct (shouldn't be too much of a pester as it is only when logging in) and if so, it will proceed like normal and if no... then, tell them to enter in the correct domain name? (or whatever you feel is best)

Describe alternatives you've considered
Double checking the domain you enter before going to the next screen.

Additional context
The failure to check for an invalid pterodactyl domain also results in an error that causes the app to get stuck on that failed url until restart (it seems)

@JordanPlayz158 JordanPlayz158 added the enhancement New feature or request label Dec 17, 2022
@JordanPlayz158 JordanPlayz158 changed the title [Suggestion] [Suggestion] Add Domain Validation when trying to login to pterodactyl instance Dec 17, 2022
@mickeydarrenlau
Copy link

The problem is there's no way to detect the domain the token is made on

@JordanPlayz158
Copy link
Author

It's not so much as knowing where the token has come from, just ensuring that the url entered is running pterodactyl for my exact suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants