Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix objectsCount in UserDefaultsStore #13

Merged
merged 1 commit into from Jan 2, 2019
Merged

[fix] Fix objectsCount in UserDefaultsStore #13

merged 1 commit into from Jan 2, 2019

Conversation

omaralbeik
Copy link
Contributor

@omaralbeik omaralbeik commented Jan 2, 2019

[fix] Fix a bug where objectsCount in UserDefaultsStore was increased even if store already has the object

@omaralbeik omaralbeik changed the title [fix] Fix a bug where objectsCount in UserDefaultsStore was not working [fix] Fix objectsCount in UserDefaultsStore Jan 2, 2019
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #13 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   89.06%   89.35%   +0.28%     
==========================================
  Files          13       13              
  Lines         558      573      +15     
==========================================
+ Hits          497      512      +15     
  Misses         61       61
Impacted Files Coverage Δ
Sources/UserDefaults/SingleUserDefaultsStore.swift 100% <ø> (ø) ⬆️
Sources/Files/FilesStore.swift 98.36% <ø> (ø) ⬆️
Sources/Files/SingleFileStore.swift 93.61% <ø> (ø) ⬆️
Sources/Keychain/SingleKeychainStore.swift 0% <ø> (ø) ⬆️
Tests/UserDefaults/UserDefaultsStoreTests.swift 100% <100%> (ø) ⬆️
Sources/UserDefaults/UserDefaultsStore.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a340bb4...4dae43f. Read the comment docs.

@omaralbeik omaralbeik merged commit 5cb669c into master Jan 2, 2019
@omaralbeik omaralbeik deleted the v1.2.1 branch January 2, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant