Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapping to Use Sources Other Than Stock #32

Open
sidrus opened this issue Apr 1, 2020 · 4 comments
Open

Update Mapping to Use Sources Other Than Stock #32

sidrus opened this issue Apr 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sidrus
Copy link
Collaborator

sidrus commented Apr 1, 2020

Actually, here is the specific post in the thread, with the beta link that includes complete JNSQ maps:
https://forum.kerbalspaceprogram.com/index.php?/topic/181688-kerbal-maps-is-back-sort-of/&do=findComment&comment=3756346

And if any code needs to changed in Telemachus to use JNSQ or ANY other pack from there,
maybe changes could/should be made to future-proof and make it easier for Telemachus to use different packs from there? (like either a UI or config/settings file for Telemachus to switch between packs, rather than having something that would need to changed, being hard-coded?) vOv
i know there was uncomfirmed comments/discussion made about maybe adding some other popular planet packs to the KM catalog, in the future... vOv

Originally posted by @StoneBlue in #19 (comment)

@sidrus sidrus added the enhancement New feature or request label Apr 1, 2020
@sidrus sidrus added this to To do in 1.x Maintenance Apr 4, 2020
@Row-Bear
Copy link
Contributor

One place I've found reference to the Kerbal Maps site is in
https://github.com/TeleIO/Telemachus-1/blob/develop/WebPages/WebPages/src/js/leafletksp.js

@StoneBlue
Copy link
Contributor

Yeah, thats where I found the reference, and swapped in the URL for the test server (w/JNSQ) maps

@sidrus sidrus self-assigned this Apr 15, 2020
@sidrus sidrus moved this from To do to In progress in 1.x Maintenance Apr 15, 2020
@sidrus
Copy link
Collaborator Author

sidrus commented Apr 15, 2020

I have a first draft of this up on development. The only maps implemented so far are the Stock/JNSQ Kerbin and Stock Mun. I will get the rest implemented over the next couple of days.

@sidrus
Copy link
Collaborator Author

sidrus commented Apr 17, 2020

So with @Row-Bear 's latest PR, we have all the bodies for both JNSQ and stock, and we have an extensible way to add more sources as they are available in Kerbal Maps. I see some improvements we can make in the UI to help declutter it a bit, but I think we've met the intent of this ticket, @StoneBlue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
1.x Maintenance
  
In progress
Development

No branches or pull requests

3 participants