Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Missing return value received when using slices.Delete #119

Closed
Deleplace opened this issue Dec 14, 2023 · 1 comment · Fixed by #120
Closed

[Bug]: Missing return value received when using slices.Delete #119

Deleplace opened this issue Dec 14, 2023 · 1 comment · Fixed by #120

Comments

@Deleplace
Copy link

Hello, while researching for this Go proposal I noticed this code:

slices.Delete(s.Messages, i, i+1)

which probably doesn't behave as intended and should look like this instead:

s.Messages = slices.Delete(s.Messages, i, i+1)

I have not tried to execute it.
@ruben-garciad ruben-garciad mentioned this issue Dec 15, 2023
Merged
@ruben-garciad
Copy link
Contributor

@Deleplace Thanks for your feedback, it's exactly a bug that could affect execution in a corner case.

@ruben-garciad ruben-garciad changed the title slices.Delete [Bug]: Missing return value received when using slices.Delete Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5420 fix: [GOLIUM] Missing return value received when using slices.Delete TelefonicaTC2Tech/golium
2 participants
@Deleplace @ruben-garciad