Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to login with QR code #469

Closed
codebam opened this issue Nov 15, 2020 · 29 comments
Closed

Unable to login with QR code #469

codebam opened this issue Nov 15, 2020 · 29 comments

Comments

@codebam
Copy link

codebam commented Nov 15, 2020

According to the login page I should go to Settings -> Devices -> Scan QR to login using a QR code however the option is not present in the Telegram FOSS app

@r4sas
Copy link

r4sas commented Nov 15, 2020

That functional dropped with Google Vision support:
a46fb6d

@codebam
Copy link
Author

codebam commented Nov 20, 2020

Oh okay, thanks for the response

@codebam codebam closed this as completed Nov 20, 2020
@trysten
Copy link

trysten commented Dec 12, 2020

IMO this is still an issue. Users expect to use QR code login, and it would be nice to have for that reason. I'm not familiar with this project, so forgive me ignorance: Why? Why did you do a46fb6d? There's no explanation in the Changelog, issues, or the commit itself. Why is there no explanation?

Unless this is wont-fix, I think this issue should be reopened.

@Younes-L
Copy link

It's explained in the readme

Removal of non-FOSS, untrustworthy or suspicious binaries or source code and their functionality:

• Google Vision face detection and barcode scanning (Passport)

Also why would users expect to use QR code in tg-foss ?
Tg-foss is not the same as telegram app, and this is one of the differences

@zk-pre
Copy link

zk-pre commented Dec 12, 2020

Assuming the QR-code is for logging in, I'd expect a foss replacement like the other features, as there are still maps and push notifications.

@jomo
Copy link

jomo commented Dec 17, 2020

I suggest using zxing as a Google Vision replacement, or opening an external barcode scanning app. zxing seems to be included in TG-FOSS already, but apparently not used here?

The login QR codes use a URL of the format tg://login?token=<base64>. They can't be used by opening them as a link though, that just shows a warning (which is a good security measure and shouldn't be changed IMO)

@bingoxo
Copy link

bingoxo commented Feb 14, 2021

please re-open the issue as a solution hasn't been implemented yet

@cooldeboy
Copy link

It's explained in the readme

Removal of non-FOSS, untrustworthy or suspicious binaries or source code and their functionality:
• Google Vision face detection and barcode scanning (Passport)

Also why would users expect to use QR code in tg-foss ?
Tg-foss is not the same as telegram app, and this is one of the differences

In socialist country , such as All we know, mobile phone numbers are required to be authenticated with real names and identity, and SMS from Telegram cannot be received, even you use a VPN.

If the QR code feature is disabled, it will cause some problems and security concerns when logging into new devices

@timonoj
Copy link

timonoj commented Apr 27, 2021

There's PLENTY of FOSS libraries for QR scanning.
https://github.com/markusfisch/BinaryEye
https://github.com/dmitriy-ilchenko/QrAndBarcodeScanner
https://github.com/AndreMiras/QrScan
https://github.com/zxing/zxing
....
The list keeps going. All these are published on F-Droid. How much would it cost to just launch an intent to a QR-reading app? I don't think you'd even need to have full integration for this.

@m-alice
Copy link

m-alice commented Sep 11, 2021

Telegram Desktop 3.0.1 keeps demand qr code
2021-09-11_11-09-23
When i use Barcode Scanner from ZXing 4.7.8, it redirect me to Telegram and i see it
Screenshot_Telegram_FOSS_20210911-111412
And, my version of Telegram Android 8.0.0 does not have the right menu item
Screenshot_Telegram_FOSS_20210911-112159
What next?

@Younes-L
Copy link

Telegram Desktop 3.0.1 keeps demand qr code

QR code is one of two login options, tdesktop isn't forcing you to use qr code

What next?

click "log in using phone number" at the bottom then proceed @m-alice
2021-09-11_11-09-23

@m-alice
Copy link

m-alice commented Sep 11, 2021

using phone number

Dear friend, i'm still waiting for a code for a whole hour.
I do not say that using SMS login is a security blow.
As a solution, i used a fork, Nekogram X - there is all right with the menu item

@timonoj
Copy link

timonoj commented Sep 16, 2021

Telegram Desktop 3.0.1 keeps demand qr code

QR code is one of two login options, tdesktop isn't forcing you to use qr code

What next?

click "log in using phone number" at the bottom then proceed @m-alice
2021-09-11_11-09-23

Please don't justify the lack of a functionality with different options that the non-FOSS also gets. This is lacking a possibly fundamental option for people that don't want to disclose their phone number in their country. So now they get to choose which kind of privacy they prefer? The closed-code one with possible tracking, or the one that can be dangerous to your own person?
It seems such an easy solution is available, with plenty of alternatives already available. Why isn't it added to the code? Just a lazy intent? Why gimp the functionality?

@gnusuari0
Copy link

If someone replaces Telegram's QR library with a libre library, would you merge that change?

@Elinvention
Copy link

I felt a bit lost when Telegram Desktop asked me to scan a QR Code and I couldn't find it.

I though I must be stupid that I can't follow basic instructions. I got angry. My stress level increased. That's no good for my health. So here I am asking to add a simple text stating that the functionality is not available in Telegram-FOSS.

@alfianrehanusa
Copy link

I felt a bit lost when Telegram Desktop asked me to scan a QR Code and I couldn't find it.

I though I must be stupid that I can't follow basic instructions. I got angry. My stress level increased. That's no good for my health. So here I am asking to add a simple text stating that the functionality is not available in Telegram-FOSS.

Actually I waste my time for searching this, and search in google instead :(

@paucazou
Copy link

Same problem with me : no sms, no message sent to telegram app, and QR code doesn't work... I just can't log in the desktop app.

@tangodev
Copy link

This is an issue. Why? Because it's making Telegram look unprofessional.

Not a long time ago I was helping someone with Telegram and I was utterly puzzled as to why they didn't see the Scan QR option. I assumed they were running an outdated version.

Fast forward to today and I'm having the same issue. "Is my client outdated? Is there something wrong with my phone?". This was a waste of time. And I also felt dumb "Why can't I find a button that's supposed to be THERE?!".

Less tech savvy users will never figure this out. They don't understand Google services and the Play Store. They deserve to have their privacy respected, but they also deserve feature parity and the same UX.

Therefore, the issue is far from "closed".

@r4sas
Copy link

r4sas commented Jan 25, 2022

@thermatk, I think we need Bountysource for such situations, where somebody wants something for free when project adressing other problems.

@thermatk
Copy link
Member

@r4sas I don't think we need bountysource, as QR codes are literally the only remaining functionality not on par with upstream as of now, considering we recently got back the heavy stuff like x86 builds

Also, the QR login supposedly works in NekoX, so the NekoX patches just need a backport at this point :)
but last time I looked it was a bit scattered across multiple commits

@thermatk
Copy link
Member

QR login seems to be a server side switch (qr_login_camera):
https://core.telegram.org/api/config

Flipping the switch here to true makes it work:

boolean hasQr = currentType == 0 && getMessagesController().qrLoginCamera;

that's a surprise 🤨

@r4sas
Copy link

r4sas commented Jan 26, 2022

I tried that already (but only with commenting out && getMessagesController().qrLoginCamera part), but that didn't make it work on local build...

@Frikster
Copy link

That functional dropped with Google Vision support: a46fb6d

If logging in by QR code was dropped then the bug is that the instructions still tell us that using a QR code is an option. There is still a bug. The QR instructions should be removed because they no longer work.

@m-alice
Copy link

m-alice commented Feb 7, 2022

Seems to be Neko 8.5.1 drop QR support too. NekoX 7.8.0 scans fine.

@thermatk
Copy link
Member

thermatk commented Feb 8, 2022

set up Bountysource ASAP, because next version will have QR code login 🤣

@tangodev
Copy link

tangodev commented Feb 9, 2022

set up Bountysource ASAP, because next version will have QR code login rofl

Please specify what you mean. QR only login? Do I understand correctly?

@Frikster
Copy link

Frikster commented Apr 3, 2022

Please specify what you mean. QR only login? Do I understand correctly?

I think he means set up a Bountysource to remove the QR code instructions and I think he is laughing because of how trivial such a fix should be, yet still a problem

@amlaku
Copy link

amlaku commented Jul 11, 2023

I have signed in before 1 weeks ago in my desktop but know I can't login by my phone number without qr code
so I can't scan it please help me

@EugeneEliot
Copy link

When I turn on the camera to scan the QR code, there is no response. what's the matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests