Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<video muted="true"> does not work #34

Open
ibc opened this issue Jan 6, 2015 · 5 comments
Open

<video muted="true"> does not work #34

ibc opened this issue Jan 6, 2015 · 5 comments

Comments

@ibc
Copy link

ibc commented Jan 6, 2015

<video autoplay muted='true'></video>

This seems not to work as there is audio (it should be muted). IMHO the following could be the reason:

 attachMediaStream = function (element, stream) {
      stream.enableSoundTracks(true);

The point is, how to mute or change the volume of the "video" / "object" element? which API is implemented?

@johache
Copy link
Contributor

johache commented Jan 6, 2015

Current state:

  • mute(d) is not supported by the plugin
  • the only way to turn the sound on and off is with stream.enableSoundTrack.
  • Or maybe setting stream.getAudioTracks()[0].enabled = false;

What would be nice:

 attachMediaStream = function (element, stream) {
      stream.enableSoundTracks(element.muted);

But since the plugin does not support element.muted, that would set the sound off for a lot of people who will not think of using stream.enableSoundTracks(true);.
This means that I will first have to implement the muted API.
I need to do a check of feasibility first.

@ibc
Copy link
Author

ibc commented Jan 6, 2015

Clear, thanks a lot.

@ekzobrain
Copy link

Hello.

What is the current state of muted API? Is there a chance that it will be implemented any time soon or should we stiil use stream manipulation?

@yocontra
Copy link

Kind of crazy how you get a stream from remote and the audio starts playing before you even render it to the DOM with the plugin, not sure if this is related to this ticket or not. I think the audio should be off by default until it gets rendered.

@yocontra
Copy link

Also related, stream.enableSoundTracks(false) does not mute the audio, there seems to be no way to turn audio off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants