Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clubs & Spades (card suits) #1578

Closed
rottekruid opened this issue Oct 16, 2016 · 8 comments
Closed

Clubs & Spades (card suits) #1578

rottekruid opened this issue Oct 16, 2016 · 8 comments
Labels
Bug A bug in an icon glyph or a first-party library. Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.

Comments

@rottekruid
Copy link

rottekruid commented Oct 16, 2016

Hi,

I would like to request the addition of the classic playing card suite icons.

Since a heart icon is available, this request is limited to the spade, diamond and club icons.

Sidenote: It would be nice if the diamond icon could serve as a mdi-checkbox-blank icon that has been rotated 45 degrees, effectively adding another primitive shape in addition to the triangle(s), circle(s) and square(s) that are already available in the set.

@rottekruid rottekruid changed the title Playing Card Suite Icons Suggestion: Playing Card Suite Icons Oct 16, 2016
@JamesCoyle JamesCoyle added the Icon Request Request for a specific icon. label Oct 16, 2016
@JamesCoyle JamesCoyle changed the title Suggestion: Playing Card Suite Icons Playing Card Suits Oct 16, 2016
@Templarian Templarian mentioned this issue Apr 4, 2017
21 tasks
@PeterShaggyNoble PeterShaggyNoble changed the title Playing Card Suits Clubs & Spades (card suits) Mar 5, 2018
@Croutonix
Copy link
Collaborator

imageimageimageimage
The spade and the club looks a bit narrow at small size though.

Download link

@PeterShaggyNoble PeterShaggyNoble added the Contribution Icon request has a contribution from either the team or someone else. label Mar 28, 2018
@CoDEmanX
Copy link

So what about stretching spade and club a bit horizontally?

@Croutonix
Copy link
Collaborator

Actually the spade is okay, but I stretched the club by 1px:
image
Download link

@Templarian Templarian added this to the Version 2.3.xx milestone Apr 1, 2018
@Templarian
Copy link
Owner

cards-heart cards-spade cards-diamond cards-club

@PeterShaggyNoble
Copy link
Collaborator

cards-club needs to be updated to the second version above.

@CoDEmanX CoDEmanX added the Bug A bug in an icon glyph or a first-party library. label Apr 4, 2018
@Croutonix
Copy link
Collaborator

Also cards-heart was just for comparison, it's the same as heart I don't think it should be duplicated.

@PeterShaggyNoble
Copy link
Collaborator

I don't think there's any harm in duplicating it in this case; it allows you to construct the icon name in code as "cards-"+<suit> instead of something like if suit="heart" then "heart" else "cards-"+suit.

@Templarian
Copy link
Owner

Agreed, I added the heart as a duplicate on purpose. Fixed the bug.

cards-club

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in an icon glyph or a first-party library. Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.
Projects
No open projects
Development

No branches or pull requests

6 participants