Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phone-location #2238

Closed
k5cents opened this issue Jul 13, 2017 · 8 comments
Closed

phone-location #2238

k5cents opened this issue Jul 13, 2017 · 8 comments
Assignees
Labels
Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.

Comments

@k5cents
Copy link

k5cents commented Jul 13, 2017

Something like account-location but with phone substituted for account within the box.

Mockup:
phone-location

Or, replace the box with a circle to more closely match Google's Find My Device icon:

find-my-device

@k5cents
Copy link
Author

k5cents commented Jul 13, 2017

Or, if somebody were able to pull the icon used by Google Play Services when Find My Device locates said device:

fmd_noti

@JamesCoyle JamesCoyle added the Icon Request Request for a specific icon. label Jul 14, 2017
@augustin32
Copy link

augustin32 commented Jul 14, 2017

Made by me,NOT extracted from G Play Services.
phone-location24
phone-location36
phone-location48

phone-location.zip

@JamesCoyle
Copy link
Collaborator

I think we should stick to square TBH. It's best we keep to a standard and a circular icon restricts the available space for the inner icon.

@PeterShaggyNoble
Copy link
Collaborator

@PeterShaggyNoble PeterShaggyNoble changed the title Request: phone-location phone-location Mar 8, 2018
@steodor
Copy link

steodor commented Feb 18, 2021

@kiernann @PeterShaggyNoble how's this for a start? Based off existing location marker and phone icons:
image
phone-location.zip

@PeterShaggyNoble
Copy link
Collaborator

We have since added map-marker as a modifier (e.g. bus-marker) so I think using that in conjunction with cellphone as the base icon to give us cellphone-marker might be the best approach here.

@steodor
Copy link

steodor commented Feb 19, 2021

@PeterShaggyNoble first of all thank you for your time! I understand what you're saying, and while i agree that cellphone-marker would be a good addition to the exiting cellphone-* range, i don't think it would be the best fit here because it reverses meaning. That icon would tell me that a location is visible / stored / accesible on my cellphone, not that my cellphone is at some location.

Thanks for giving me a hint about the naming though (i didn't pay enough attention initially, sorry), so keeping in line with the rest of the library i guess map-marker-cellphone would be appropriate for placing phones on a map.

Also i fixed the cellphone shape to bring it closer to the one used in monitor-cellphone, which looks much better. It's just 1dp narrower to allow for centering without having subpixel antialiasing making its edges blurry at native resolution. What do you think?
image
map-marker-cellphone.zip

@mririgoyen
Copy link
Sponsor Collaborator

tooltip-cellphonecellphone-marker

@mririgoyen mririgoyen self-assigned this Sep 1, 2021
@mririgoyen mririgoyen added the Contribution Icon request has a contribution from either the team or someone else. label Sep 1, 2021
@mririgoyen mririgoyen added this to the Next Minor - 6.2.xx milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.
Projects
None yet
Development

No branches or pull requests

6 participants