Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector-point-(plus|minus|edit) #4518

Closed
moovida opened this issue Oct 16, 2019 · 6 comments
Closed

vector-point-(plus|minus|edit) #4518

moovida opened this issue Oct 16, 2019 · 6 comments
Labels
Breaking Change Issues is has a change that will break something in the next release. Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.

Comments

@moovida
Copy link

moovida commented Oct 16, 2019

I have:

  • [x ] Searched open issues to make sure there isn't a request for this icon.
  • [x ] Followed the material guidelines.

This is a followup on a suggestion in #4503. I assume opening a new issue with proper naming is the correct way to go.

Preview

image

image

image

image

Zip Download

box.zip

@moovida moovida added Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon. labels Oct 16, 2019
@Templarian Templarian changed the title box-(plus|minus|edit) vector-point-(plus|minus|edit) Oct 16, 2019
@Templarian
Copy link
Owner

Need to figure out naming around vector-point already existing, but we can probably rename that one and add these.

What is vector-point-edit for @moovida?

@moovida
Copy link
Author

moovida commented Oct 17, 2019

@Templarian , when you have a layer of vector points, you would use it for a tool that allows to move the single points. Talking about GIS, that would mean change interactively the planimetric coordinates of the point. So it would actually mean to move the whole box as a single entity. Hmmm, I see your point.

@Templarian
Copy link
Owner

We'll need to add a -remove also. But this seems doable. I'm not sure adding the -edit makes sense.

Maybe a mouse cursor and a vector-point ?

@moovida
Copy link
Author

moovida commented Oct 17, 2019

Adding a remove makes sense.

The problem with not having an editing version is that then the line and polygon editing icons would not be consistent. The mouse cursor could make sense also for the line and polygon editing though, if it points to one of the vertexes in all icons.

@mririgoyen mririgoyen added the Breaking Change Issues is has a change that will break something in the next release. label Sep 2, 2021
@mririgoyen mririgoyen added this to the Next Major - 7.0.xx milestone Sep 2, 2021
@mririgoyen
Copy link
Sponsor Collaborator

mririgoyen commented Sep 2, 2021

Wish I would have saw this before we cut the v6 release. Due to the rename of vector-point, this will have to wait until our next major version. Tagged and updated.

We'll rename out current vector-point to vector-point-select and then add these in using vector-point as the base.

@mririgoyen
Copy link
Sponsor Collaborator

vector-pointvector-point-edit
vector-point-plusvector-point-minus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Issues is has a change that will break something in the next release. Contribution Icon request has a contribution from either the team or someone else. Icon Request Request for a specific icon.
Projects
None yet
Development

No branches or pull requests

3 participants