Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename text-to-speech to microphone-message #6555

Closed
nagyrobi opened this issue Apr 22, 2022 · 4 comments
Closed

Rename text-to-speech to microphone-message #6555

nagyrobi opened this issue Apr 22, 2022 · 4 comments
Assignees
Labels
Breaking Change Issues is has a change that will break something in the next release. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. Icon Update Icon needs to be updated but is not a bug or high priority.

Comments

@nagyrobi
Copy link

nagyrobi commented Apr 22, 2022

Where are you experiencing this bug?

A specific icon glyph

What is the issue you are experiencing?

tts ttsoff

This icon is incorrectly named as text-to-speech. It should be named speech-to-text.

speech-to-text marks the technology needed to capture audio and recognize the speech transforming it in written text.
text-to-speech marks the reverse of this, is technology needed to transform written text to audible speech

When representing these, a good approach is to look at the interface which is closest to the users. For speech-to-text this is a microphone, as usually the user speaks into a microphone in order for the speech to be recognized by a system. For text-to-speech this is a speaker, as the text transformed to speech is usually played out via speakers.

So the icon above representing a microphone with a bubble is more appropriate for speech-to-text.

For text-to-speech I suggest to create a version based on speaker-wireless, where the waves on the right are replaced by the bubble fom cellphone-message, something like below:

kép
(no need for an off version imho)

Tag should also be tts.

Use case is for a Home Automation system where the speaker icons associated to media players change based on what the player does. Playing out a TTS message via speakers looks very strange (and concerning) while showing a microphone...

@nagyrobi nagyrobi added the Bug A bug in an icon glyph or a first-party library. label Apr 22, 2022
@mririgoyen
Copy link
Sponsor Collaborator

mririgoyen commented Apr 22, 2022

Thanks for the feedback. This really isn't a bug though, but a request to rename an existing icon. (Just for future reference. 😄)

That being said, I think the icon is named too literal to begin with. I would prefer to see the current text-to-speech icons renamed to something more generic, such as microphone-message (following a pattern we begun with cellphone-message). We can then add new speaker-message(-off) icons.

Because an icon rename is a breaking change, this won't happen until v7, which is a few releases away. I'm going to repurpose this issue to handle the icon rename of text-to-speech and I opened a new issue to track adding the speaker: #6557.

@mririgoyen mririgoyen added Breaking Change Issues is has a change that will break something in the next release. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. Icon Update Icon needs to be updated but is not a bug or high priority. and removed Bug A bug in an icon glyph or a first-party library. labels Apr 22, 2022
@mririgoyen mririgoyen added this to the Next Major - 7.0.xx milestone Apr 22, 2022
@mririgoyen
Copy link
Sponsor Collaborator

mririgoyen commented Apr 22, 2022

In this issue, we will rename:

  • text-to-speechmicrophone-message
  • text-to-speech-offmicrophone-message-off

We will add text-to-speech as aliases so the icons can continue to be found under their old names.

@mririgoyen mririgoyen self-assigned this Apr 22, 2022
@mririgoyen mririgoyen changed the title text-to-speech needs rename + request to add the real one Rename text-to-speech to microphone-message Apr 22, 2022
@nagyrobi
Copy link
Author

Thank you.

@mririgoyen
Copy link
Sponsor Collaborator

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Issues is has a change that will break something in the next release. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. Icon Update Icon needs to be updated but is not a bug or high priority.
Projects
None yet
Development

No branches or pull requests

2 participants