Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenFaas functions are not getting invoked everytime there is a message for that topic #26

Closed
milly21 opened this issue Feb 27, 2019 · 9 comments · Fixed by #27
Closed
Assignees
Labels
bug Something isn't working verified Bug was reproducible

Comments

@milly21
Copy link

milly21 commented Feb 27, 2019

General Information

Environment
OpenFaas is deployed locally on kubernetes(using Minikube)
Rabbitmq and rabbitmq connector is deployed on on kubernetes(using Minikube)

Connector Version
Latest version

Bug Details

Describe the bug
When I send messages to different topics, the OpenFaas function is not getting invoked every time.
Expected behaviour
I expect OpenFaas function to get invoked every time there is a message for that topic to which openfaas function is subscribed.

Steps to Reproduce
Set RMQ_TOPICS: "input,output"
Using faas-cli to deploy OpenFaas function
faas-cli store deploy Colorization --annotation topic="output"
faas-cli store deploy fillet --annotation topic="input"

Checking whether function is invoked or not with faas-cli list

Sending messages to the OpenFaaSQueue and topics(input, output) with a python client.

Please let me know if you need any more information.

@milly21 milly21 added bug Something isn't working investigate Have a look, before procceeding labels Feb 27, 2019
@milly21 milly21 changed the title [OpenFaas function are not getting invoked everytime there is a message for that topic] [OpenFaas functions are not getting invoked everytime there is a message for that topic] Feb 27, 2019
@milly21
Copy link
Author

milly21 commented Feb 27, 2019

Looked at Rabbitmq connector logs and I am getting message"Should not happen" when the function is not getting invoked.

@Templum
Copy link
Owner

Templum commented Feb 27, 2019

Alright, thanks for the input. I will try to reproduce it.

I will get back to you in case I require further input.

@Templum
Copy link
Owner

Templum commented Feb 27, 2019

@milly21 I was able to reproduce the issue. I'm currently working on a fix for this. I will ping you again, once it is finished. Further, I will also link the PR, so you should be able to see the progress.

@Templum Templum added verified Bug was reproducible and removed investigate Have a look, before procceeding labels Feb 27, 2019
@Templum
Copy link
Owner

Templum commented Feb 27, 2019

@milly21 could you be so kind and retest if templum/rabbitmq-connector:pr-27 resolves the issues you experience?

@Templum Templum changed the title [OpenFaas functions are not getting invoked everytime there is a message for that topic] [BUG] OpenFaas functions are not getting invoked everytime there is a message for that topic Feb 27, 2019
@Templum Templum self-assigned this Feb 27, 2019
@milly21
Copy link
Author

milly21 commented Feb 28, 2019

Yes sure, I will test the changes.

@milly21
Copy link
Author

milly21 commented Feb 28, 2019

Do I need to add OpenFaaS_Topic in the connector-cfg.yml file?

@Templum
Copy link
Owner

Templum commented Feb 28, 2019

No it will now spawn an dedicated Queue per Topic. It basically Prefixes the topic with OpenFaaS_. I believe it should work out of the box, no new config parameter was added.

@milly21
Copy link
Author

milly21 commented Feb 28, 2019

Thank you. I just tested. It seems to be working well for me. I will do a load test as well.

@Templum
Copy link
Owner

Templum commented Mar 1, 2019

Alright, I will later merge the PR. Thanks for the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified Bug was reproducible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants