Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The color doesn't match after changing into clothes #13

Closed
xiaoboelse opened this issue May 4, 2024 · 5 comments
Closed

The color doesn't match after changing into clothes #13

xiaoboelse opened this issue May 4, 2024 · 5 comments

Comments

@xiaoboelse
Copy link

Thank you for the author's efforts, but the testing was slow and the size did not match well. It must be a multiple of 8, and the most crucial thing is that the color did not match after changing into clothes
微信截图_20240504115339

@taoisu
Copy link

taoisu commented May 7, 2024

Confirming the same issue. On the other hand, this demo page is giving the right result: https://huggingface.co/spaces/yisol/IDM-VTON

Is there a bug?

@TemryL
Copy link
Owner

TemryL commented May 7, 2024

Hi guys, yes it is a bug that needs to be fixed! I think it comes from the mask generation with SAM because in the demo the mask is much bigger and does not cover only the clothe but the whole upper body. One idea could be to try to load a manually generated mask and see what happens. If their is still a mismatch color, then probably the preprocessing of the images in the inference pipeline is wrong. Let me know if you can investigate on that. Thanks!

@whitepapercg
Copy link
Contributor

whitepapercg commented May 7, 2024

Hi guys, yes it is a bug that needs to be fixed! I think it comes from the mask generation with SAM because in the demo the mask is much bigger and does not cover only the clothe but the whole upper body. One idea could be to try to load a manually generated mask and see what happens. If their is still a mismatch color, then probably the preprocessing of the images in the inference pipeline is wrong. Let me know if you can investigate on that. Thanks!

Hello!
I tried using different masks, it didn't help

Also, I compared your code and the original code and didn't notice any errors or misspellings.

@TemryL
Copy link
Owner

TemryL commented May 8, 2024

I just updated the input preprocessing which should give more consistent results.

Feel free to try again with your inputs and share your outputs here?

Cheers!

@01-111162-173
Copy link

it has the same question now, the color is not match the garment color, for ex. the garment color is black, generate image is gray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants