Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Replace runtime exception with rss related exception in… #8

Merged
merged 4 commits into from Nov 10, 2021

Conversation

colinmjj
Copy link
Collaborator

@colinmjj colinmjj commented Nov 9, 2021

What changes were proposed in this pull request?
This PR add RSS related exception which can be identify there has some problem in shuffle server

Why are the changes needed?
Improve the exception

Does this PR introduce any user-facing change?
No

How was this patch tested?
base on current UT

@jerqi
Copy link
Collaborator

jerqi commented Nov 9, 2021

We replace runtimeException in class ShuffleGrpcClient with RssCausedException

@colinmjj colinmjj added the enhancement New feature or request label Nov 9, 2021
@colinmjj
Copy link
Collaborator Author

colinmjj commented Nov 9, 2021

We replace runtimeException in class ShuffleGrpcClient with RssCausedException

Exception in ShuffleGrpcClient means network problem or shufffle server problem.
The pr is target to throw RssCausedException and can be seen by spark directly, it will help event listener to catch it easily

@jerqi
Copy link
Collaborator

jerqi commented Nov 9, 2021

We replace runtimeException in class ShuffleGrpcClient with RssCausedException

Exception in ShuffleGrpcClient means network problem or shufffle server problem. The pr is target to throw RssCausedException and can be seen by spark directly, it will help event listener to catch it easily

But these exceptions are also caused by rss.

@colinmjj
Copy link
Collaborator Author

colinmjj commented Nov 9, 2021

We replace runtimeException in class ShuffleGrpcClient with RssCausedException

Exception in ShuffleGrpcClient means network problem or shufffle server problem. The pr is target to throw RssCausedException and can be seen by spark directly, it will help event listener to catch it easily

But these exceptions are also caused by rss.

ok, do the replacement

@colinmjj
Copy link
Collaborator Author

@jerqi update pr according to comments

@jerqi
Copy link
Collaborator

jerqi commented Nov 10, 2021

ShuffleWriteClientImpl also need to be replaced.

@colinmjj
Copy link
Collaborator Author

ShuffleWriteClientImpl also need to be replaced.

done

@colinmjj colinmjj merged commit 1cb3f35 into Tencent:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants