New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Replace runtime exception with rss related exception in… #8
Conversation
client-spark/common/src/main/java/org/apache/spark/shuffle/RssCausedException.java
Outdated
Show resolved
Hide resolved
We replace runtimeException in class ShuffleGrpcClient with RssCausedException |
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java
Outdated
Show resolved
Hide resolved
Exception in ShuffleGrpcClient means network problem or shufffle server problem. |
But these exceptions are also caused by rss. |
ok, do the replacement |
@jerqi update pr according to comments |
ShuffleWriteClientImpl also need to be replaced. |
done |
What changes were proposed in this pull request?
This PR add RSS related exception which can be identify there has some problem in shuffle server
Why are the changes needed?
Improve the exception
Does this PR introduce any user-facing change?
No
How was this patch tested?
base on current UT