Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some unused variable in aes_core.c #11

Closed
iOSleep opened this issue Sep 21, 2018 · 3 comments
Closed

some unused variable in aes_core.c #11

iOSleep opened this issue Sep 21, 2018 · 3 comments

Comments

@iOSleep
Copy link

iOSleep commented Sep 21, 2018

The language of MMKV

Swift

The version of MMKV

v1.0.10

The platform of MMKV

iOS

The installation of MMKV

Cocoapods

What's the issue?

Post the outputs or screenshots for errors.

image

Explain what you want by example or code in English.

What are these things doing?And can we remove these unused variable?

@lingol
Copy link
Collaborator

lingol commented Sep 21, 2018

Thanks for the feedback.
I have notice these warnings before making MMKV public. I chose to ignore it because it's OpenSSL's code, and changing another lib's code is something complicate in law.

Please let me know if there's a better way.

@foobra
Copy link

foobra commented Sep 21, 2018

@lingol you can warp the code with #pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wno-unused-variable"

...
#endif

#pragma clang diagnostic pop

@lingol
Copy link
Collaborator

lingol commented Sep 23, 2018

@lingol you can warp the code with #pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wno-unused-variable"

...
#endif

#pragma clang diagnostic pop

Fixed by pr pr#19.

@lingol lingol closed this as completed Sep 26, 2018
@sven-brobonds sven-brobonds mentioned this issue Jul 21, 2020
@billdizl billdizl mentioned this issue Apr 28, 2022
Closed
This was referenced Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants