iOS & Objective-C no type detection for Key

[yuman07]

The language of MMKV

Objective-C

The version of MMKV

v1.0.10

The platform of MMKV

iOS

The installation of MMKV

Cocoapods

What's the issue?

I found that all set&get methods call 'key.length' for check key vaild, but the passed key will be crash if it is an id type but not a string.

[yuman07]

if (!key || ![key isKindOfClass:[NSString class]] || key.length == 0) {
    return;
}

I think this will be better!

[lingol]

Well, the interface is
- (BOOL)setxxx forKey:(NSString *)key;
Notice the type of key is specify here, requiring NSString. Let your code-checking-tool do the job.

And one more thing, checking parameter's type is a little luxurious for a frequently called interface.

[rizwankce]

Agree with @lingol here.

interface is specifically mentioning the type of the parameter. To force the user not to send anything else we could use some assertions NSAssert with message. So developers will get error/warning when they run into issues of sending wrong type.