Optimize speed of spliting template and data from html data #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
- replaceOccurrencesOfString:withString:options:range:
to replace tag. But it's not efficient and much time cost. It needs to scan whole file to replace.I run a performance test to compare the new(my
PR
) and old(framework currently implementation), split the framework demomain.html
1000 times, results are below:Used
main.html
:Used
main.html
but has 10 data tag:Used
main.html
but has 20 data tag:Used
main.html
but has 20 data tag, and double file size:Conclusion:
Along with increasing of
data
tag or file size, the old method's cost is increasing much higher. For the last test, new split method is at least 6ms faster than old way.