Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 #1225

Closed
jsonwan opened this issue Aug 25, 2022 · 2 comments
Closed

bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 #1225

jsonwan opened this issue Aug 25, 2022 · 2 comments
Assignees
@jsonwan
Labels
kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy stage/uat UAT environment in tencent has been deploy
Milestone
V3.5.1

Comments

@jsonwan
Copy link
Collaborator

jsonwan commented Aug 25, 2022

Version / Branch / tag
3.5.x

出了什么问题？(What Happened?)
全局设置消息预览在发送失败的情况下仍提示发送成功

如何复现？(How to reproduce?)
全局设置消息预览，选择正确的人员与异常的消息通道发送消息进行预览

预期结果(What you expect?)
在发送失败的情况下提示发送失败
@jsonwan jsonwan added the kind/bug 程序故障Bug，漏洞 label Aug 25, 2022
@jsonwan jsonwan self-assigned this Aug 25, 2022
@jsonwan
Copy link
Collaborator Author

jsonwan commented Aug 25, 2022

原因：发送消息时使用了异步线程进行发送，无法及时感知到发送结果，因此一直报发送成功，应改为同步调用。

jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
7eb0b3b
jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
8e83e74 
优化报错信息
jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
3f529f9 
优化报错信息
jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
018f41e 
更新版本号
@jsonwan
Copy link
Collaborator Author

jsonwan commented Sep 7, 2022

image

jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
979dea6 
代码优化
jsonwan added a commit to jsonwan/bk-job that referenced this issue Sep 7, 2022
@jsonwan
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 TencentBlueKing#1225
a5e8741 
代码优化
jsonwan added a commit that referenced this issue Sep 7, 2022
@jsonwan
Merge pull request #1257 from jsonwan/github_fix/notify_preview
2795654 
bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 #1225
@bkjob-bot bkjob-bot added the stage/test Test environment in tencent has been deploy label Sep 8, 2022
@jsonwan jsonwan added this to the V3.5.1 milestone Sep 8, 2022
@nekzhang nekzhang closed this as completed Sep 8, 2022
@bkjob-bot bkjob-bot added stage/prod Production environment in tencent has been deploy stage/uat UAT environment in tencent has been deploy labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsonwan jsonwan

Labels
kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy stage/uat UAT environment in tencent has been deploy
Projects
None yet
Milestone
V3.5.1
Development

No branches or pull requests
3 participants
@nekzhang @jsonwan @bkjob-bot