Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440

Closed
wangyu096 opened this issue Oct 28, 2022 · 1 comment
Closed

bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440

wangyu096 opened this issue Oct 28, 2022 · 1 comment
Assignees
@wangyu096
Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy

Comments

@wangyu096
Copy link
Collaborator

Version / Branch / tag
3.4.6.0 - 3.6.x

出了什么问题？(What Happened?)

用户自定义的高危语句规则不合法，导致后端处理报错，进而导致其他合法的高危语句规则也没有检测到

image

如何复现？(How to reproduce?)

见问题描述

预期结果(What you expect?)

  1. 保存高危语句规则，需要检验表达式是否合法
  2. 如果检测过程中报错，直接返回报错给调用方
@wangyu096 wangyu096 added the kind/bug 程序故障Bug，漏洞 label Oct 28, 2022
@wangyu096 wangyu096 self-assigned this Oct 28, 2022
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
8b1f4aa
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
fbe9898
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
7f17767
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
7db0b54
jsonwan added a commit that referenced this issue Nov 8, 2022
@jsonwan
Merge pull request #1451 from wangyu096/3.5.x
bef25c6 
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
04196f0
wangyu096 added a commit that referenced this issue Nov 8, 2022
@wangyu096
Merge pull request #1452 from wangyu096/3.6.x
cae0846 
[3.6.x]bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Nov 8, 2022
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
846e007
wangyu096 added a commit that referenced this issue Nov 8, 2022
@wangyu096
Merge pull request #1453 from wangyu096/issue_1440
1d5905f 
[master]bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440
@bkjob-bot bkjob-bot added the stage/test Test environment in tencent has been deploy label Nov 11, 2022
@bkjob-bot bkjob-bot added the stage/prod Production environment in tencent has been deploy label Nov 14, 2022
@fabio-he
Copy link
Collaborator

image

wangyu096 added a commit to wangyu096/bk-job that referenced this issue Jan 30, 2023
@wangyu096
bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 TencentBlueKing#1440
2c83896
wangyu096 added a commit that referenced this issue Jan 30, 2023
@wangyu096
Merge pull request #1700 from wangyu096/3.4.x
c5342f6 
[3.4.x]bugfix: 高危语句检测存在一个正则失败的规则会导致所有该种类所有规则不生效 #1440
@bkjob-bot bkjob-bot added the done 已上线到正式环境并验收通过 label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangyu096 wangyu096

Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wangyu096 @fabio-he @bkjob-bot