Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 #1554

Closed
jsonwan opened this issue Nov 30, 2022 · 2 comments
Closed

bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 #1554

jsonwan opened this issue Nov 30, 2022 · 2 comments
Assignees
@hLinx @wangyu096 @jsonwan
Labels
kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy

Comments

@jsonwan
Copy link
Collaborator

jsonwan commented Nov 30, 2022

Version / Branch / tag
3.5.x

出了什么问题？(What Happened?)
公共脚本修改后标签消失

如何复现？(How to reproduce?)
选择已有的公共脚本，修改，保存

预期结果(What you expect?)
公共脚本修改保存后标签依然存在
@jsonwan jsonwan added the kind/bug 程序故障Bug，漏洞 label Nov 30, 2022
@jsonwan jsonwan self-assigned this Nov 30, 2022
@jsonwan
Copy link
Collaborator Author

jsonwan commented Dec 1, 2022

业务脚本也存在同样的问题，需要修复

@wangyu096 wangyu096 self-assigned this Dec 2, 2022
@wangyu096 wangyu096 changed the title bugfix: 公共脚本修改后标签消失 bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 Dec 2, 2022
@wangyu096
Copy link
Collaborator

问题原因：

在脚本版本的新增/更新场景，API中并不包含标签数据。但是由于新建/更新脚本、脚本版本的API是复用的，无论是什么场景，都会去更新标签，就导致了在更新脚本版本的情况下，清空了脚本上的标签数据。

wangyu096 added a commit to wangyu096/bk-job that referenced this issue Dec 2, 2022
@wangyu096
bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 TencentBlueKing#1554
e6f6dde
@wangyu096 wangyu096 mentioned this issue Dec 2, 2022
Merged
jsonwan added a commit that referenced this issue Dec 2, 2022
@jsonwan
Merge pull request #1575 from wangyu096/issue_1554
c3aa04f 
bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 #1554
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Dec 2, 2022
@wangyu096
bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 TencentBlueKing#1554
8f3e5ea
wangyu096 added a commit that referenced this issue Dec 2, 2022
@wangyu096
Merge pull request #1576 from wangyu096/issue_1554_3.6.x
a611346 
[3.6.x] bugfix: 新增/编辑脚本版本，会导致脚本上的标签丢失 #1554
@bkjob-bot bkjob-bot added the stage/test Test environment in tencent has been deploy label Dec 14, 2022
@bkjob-bot bkjob-bot added the stage/prod Production environment in tencent has been deploy label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hLinx hLinx

@wangyu096 wangyu096

@jsonwan jsonwan

Labels
kind/bug 程序故障Bug，漏洞 stage/prod Production environment in tencent has been deploy stage/test Test environment in tencent has been deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hLinx @wangyu096 @jsonwan @bkjob-bot