Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breadcrumb] target设置无效 #3634

Closed
JunQiGenYuan opened this issue Nov 23, 2023 · 6 comments
Closed

[breadcrumb] target设置无效 #3634

JunQiGenYuan opened this issue Nov 23, 2023 · 6 comments
Labels
🙏🏻 help wanted Extra attention is needed to be published to be published

Comments

@JunQiGenYuan
Copy link

tdesign-vue 版本

latest

重现链接

No response

重现步骤

<t-breadcrumb :max-item-width="'150'" class="pb-4" > <t-breadcrumbItem href="/xxxxxx" target="_parent" > xxxx </t-breadcrumbItem> <t-breadcrumbItem>xxxxx</t-breadcrumbItem> </t-breadcrumb>

期望结果

能识别target，与默认的a标签一样行为，如触发父窗口跳转等。

实际结果

target无论怎么设置，都只跳转当前窗口或iframe

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

源码位置：https://github.com/Tencent/tdesign-vue-next/blob/develop/src/breadcrumb/breadcrumb-item.tsx#L67
只设置了href、没有设置route，不应该阻止默认行为,把e.preventDefault();移动到 if (props.href) 的else等执行即可
@github-actions GitHub Actions
Copy link
Contributor

👋 @JunQiGenYuan，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited

♥️ 有劳 @Ogurimuio @Blackn-L @Blackn-L 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @JunQiGenYuan 。

@uyarn uyarn added to be published to be published and removed to be published to be published labels Nov 23, 2023
@uyarn uyarn transferred this issue from Tencent/tdesign-vue Nov 23, 2023
@uyarn uyarn added the 🙏🏻 help wanted Extra attention is needed label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

👋 @JunQiGenYuan，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@Summer-Shen
Copy link
Contributor

Summer-Shen commented Nov 24, 2023 •
edited

可以领取这个 issue 吗？预计近几天完成。 （已有相关 PR）

@uyarn
Copy link
Collaborator

uyarn commented Nov 24, 2023

可以领取这个 issue 吗？预计近几天完成。

PR is welcome

@selicens selicens mentioned this issue Nov 24, 2023
Merged
16 tasks
@PengYYYYY PengYYYYY added the to be published to be published label Nov 26, 2023
@github-actions github-actions bot mentioned this issue Dec 6, 2023
Merged
16 tasks
@uyarn
Copy link
Collaborator

uyarn commented Dec 8, 2023

fixed 1.7.1

@uyarn uyarn closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙏🏻 help wanted Extra attention is needed to be published to be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JunQiGenYuan @uyarn @PengYYYYY @Summer-Shen