Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packaging] setup.py doesn't contain list of requirements #17

Closed
mbukatov opened this issue Jan 3, 2017 · 2 comments
Closed

[packaging] setup.py doesn't contain list of requirements #17

mbukatov opened this issue Jan 3, 2017 · 2 comments

Comments

@mbukatov
Copy link
Contributor

mbukatov commented Jan 3, 2017

It's not possible to properly install tendrl-alerting project via pip, because setup.py is not aware of required python modules.

Reproducer

Install the project via pip from sources:

$ cd ~/projects/tendrl.org/alerting/
$ virtualenv .env
$ source .env/bin/activate
$ pip install .
$ pip list

Actual result

$ pip list
DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning.
pip (9.0.1)
setuptools (32.3.1)
tendrl-alerting (1.1)
wheel (0.30.0a0)

Expected result

The output of pip list contains all dependencies of the project.
@mbukatov
Copy link
Contributor Author

mbukatov commented Jan 3, 2017 •
edited
Loading

See a similar issues:

@mbukatov mbukatov mentioned this issue Jan 3, 2017
Closed
@mbukatov mbukatov mentioned this issue Jan 16, 2017
Merged
@mbukatov mbukatov mentioned this issue Feb 22, 2017
Closed
@mbukatov
Copy link
Contributor Author

Fixed by #38

anmolbabu pushed a commit to anmolbabu/alerting that referenced this issue Mar 23, 2017
@mbukatov @anmolbabu
move deps into setup.py, keep requirements.txt files
ff4d512 
Option install_requires in setup.py contains names of all python modules
tednrl-alerting depends on, including tendrl-alerting.

For development and CI purposes, there are requirements.txt files as
well. The main difference between them is the github branch they use to
install other tendrl components from:

* requirements.develop.txt (uses develop branch)
* requirements.master.txt (uses master branch)

So in CI or development enviroment, one can install tendrl-alerting
into virtualenv like this::

    pip install -r requirements.master.txt

Based on description from:

* https://packaging.python.org/requirements/
* https://caremad.io/posts/2013/07/setup-vs-requirement/

tendrl-bug-id: Tendrl#17
tendrl-bug-id: Tendrl#18
tendrl-bug-id: Tendrl#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbukatov