Add alerting manager, definations and generic exceptions #22
Conversation
|
@Tendrl/tendrl-core This is a split PR of #15 Please review |
| @@ -0,0 +1,47 @@ | |||
| # flake8: noqa | |||
There was a problem hiding this comment.
Name of the file should be something like tendrl_definitions_alerting.py.
Also the package name followed in other cases are like tendrl/{module}/manager. Can we think of something similar?
| type: json | ||
| Alert: | ||
| attrs: | ||
| alert_id: |
| from tendrl.common import log | ||
|
|
||
|
|
||
| LOG = logging.getLogger(__name__) |
| config.get('alerting', 'log_cfg_path'), | ||
| config.get('alerting', 'log_level') | ||
| ) | ||
| manager = Manager() |
There was a problem hiding this comment.
The name of this class could be AlertingManager and it should extend from common's Manager class.
There was a problem hiding this comment.
common's manager cannot be extended here because, it has certain things like the discovery_thread among others which are not used anywhere in monitoring as of now. Also this manager needs to be a multiprocessing.Process as it has blocking calls in some of the managers managed by this manager
| @@ -0,0 +1,75 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Need to remove this file as its no more required.
tendrl-bug-id: #10,#11,#12,#14
Signed-off-by: anmolbabu anmolbudugutta@gmail.com