Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to etcd keys which are not present #61

Closed
mulbc opened this issue Jan 25, 2017 · 3 comments
Closed

Access to etcd keys which are not present #61

mulbc opened this issue Jan 25, 2017 · 3 comments

Comments

@mulbc
Copy link

mulbc commented Jan 25, 2017

Tendrl-api is trying to access keys on first boot, which are not present. This causes a complete failure and no apparent way to fix it.

@mkudlej
Copy link

mkudlej commented Jan 26, 2017

I think this is knows issue. QE opinion is here #31 (comment)
Summary: API should clearly report issue and it should not crash with stacktrace.

@brainfunked
Copy link
Contributor

This particular key is absolutely mandatory for the API to function. While the exception could be caught and handled, the response to the requests would still be a 5xx. This is because the prerequisites for the API to function aren't setup and no queries can be responded to.

The best I can think of is to provide a helpful message as a response rather than a backtrace.

@anivargi
Copy link
Contributor

anivargi commented Mar 3, 2017

@zeichenanonym The API never tries to load anything from etcd (keys) when it is started, it only looks for the etcd config.
If you have a proper etcd config and you try hostname/api/1.0/ping the API does handle it and returns a {"errors":{"message":"Not found."}} with 404 HTTP status.

The purpose of the ping in this case is to know everything is configured properly with definitions file.

We could add something like /api/1.0/status to just know if the API is up and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants