Added few more details for installation guidelines #31
Conversation
|
@r0h4n @nthomas-redhat @brainfunked @nnDarshan @anmolbabu please review. |
|
|
||
| $ yum install python-devel gcc # Install dependencies |
There was a problem hiding this comment.
I dont think we should have distro specific details in install files.
Either make install files for centos, fedora, ubuntu, or add all those details here
There was a problem hiding this comment.
Done changes as per ceph_bridge's PR Tendrl/ceph-integration#15
|
@r0h4n done the changes as per suggestions. Please review.. |
|
@r0h4n @brainfunked @nthomas-redhat Please review and approve. |
|
|
||
| $ git clone https://github.com/Tendrl/bridge_common.git | ||
| $ cd bridge_common | ||
| $ mkvirtualenv ceph_bridge |
There was a problem hiding this comment.
Oh yeah :) Copy-Paste issue. Will correct it as below
mkvirtualenv bridge_common
|
Rabased and pushed again. Please review and approve.. |
|
Fix travis failures |
| 4. Edit ``/etc/tendrl/tendrl.conf`` as required |
There was a problem hiding this comment.
Can we add a reference to sample conf file here if it exists or add one and refer it here so that things like the conf file format and also the neessary fields of conf file can be easily known
There was a problem hiding this comment.
Its small change so should be ok I feel.
| $ git clone https://github.com/Tendrl/bridge_common.git | ||
| $ cd bridge_common | ||
| $ mkvirtualenv bridge_common | ||
| $ pip install . |
There was a problem hiding this comment.
can we just simply add a reference to these steps in bridge common instead of having to put the steps here again
There was a problem hiding this comment.
Earlier it was like that. But better user refers one and has the setup ready. so its OK I feel. Still if everybody feels strongly to refer from common, can be done :)
| virtual enviroment`_. This way, we install *gluster bridge* into the same virtual | ||
| enviroment which we have created during installation of *bridge common*. | ||
|
|
||
| .. _virtualenvwrapper: https://virtualenvwrapper.readthedocs.io/en/latest/ |
There was a problem hiding this comment.
I liked this note as it is informative.At-least I was not aware of this before reviewing this and was struggling to get this kind of thing working for my monitoring related stuff. Thanks ...
Signed-off-by: Shubhendu <shtripat@redhat.com>
Signed-off-by: Shubhendu <shtripat@redhat.com>
Signed-off-by: Shubhendu <shtripat@redhat.com>
Signed-off-by: Shubhendu <shtripat@redhat.com>
Signed-off-by: Shubhendu shtripat@redhat.com