Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the volume entry from etcd as well while volume delete #73

Closed
shtripat opened this issue Nov 29, 2016 · 7 comments
Closed

Delete the volume entry from etcd as well while volume delete #73

shtripat opened this issue Nov 29, 2016 · 7 comments
Assignees
@shtripat

Comments

@shtripat
Copy link
Member

Currently the volume is marked as deleted=True as an stop gap arrangement. Modify the same to delete the etcd entry post volume deletion flow.
@shtripat
Copy link
Member Author

shtripat commented Dec 8, 2016 •
edited

This is taken care as part of #63

@shtripat shtripat mentioned this issue Dec 12, 2016
Closed
@r0h4n
Copy link
Contributor

r0h4n commented Dec 15, 2016

  • Once we delete any object in etcd, we set its "deleted" flag as true.
  • @Tendrl/tendrl_api needs to respect this flag for list views for all objects

@shtripat
Copy link
Member Author

@r0h4n so as part of my PR, if the record is permanently deleted from etcd the api listing GetVolumeList would not get the removed ones. So I dont see an issue as such.

shtripat pushed a commit to shtripat/gluster_bridge that referenced this issue Dec 15, 2016
Remove volume from central store while delete flow execution
0973e7b 
tendrl-bug-id: Tendrl#73

Signed-off-by: Shubhendu <shtripat@redhat.com>
@r0h4n
Copy link
Contributor

r0h4n commented Dec 16, 2016

@Tendrl/tendrl_api Please respond to above issue

@anivargi
Copy link

Tendrl/api#44

shtripat pushed a commit to shtripat/gluster_bridge that referenced this issue Jan 12, 2017
Remove volume from central store while delete flow execution
ed19cd0 
tendrl-bug-id: Tendrl#73

Signed-off-by: Shubhendu <shtripat@redhat.com>
@sankarshanmukhopadhyay
Copy link
Contributor

Is this and the referenced issue fixed?

@r0h4n
Copy link
Contributor

r0h4n commented Feb 24, 2017

This one is fixed. Tendrl now hard deletes volumes from its central store

@r0h4n r0h4n closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shtripat shtripat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@r0h4n @sankarshanmukhopadhyay @shtripat @anivargi