Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumes list should include Volume Profiling column and Enable/Disable Profiling action button [RFE] #819

Closed
julienlim opened this issue Feb 15, 2018 · 5 comments

Comments

@julienlim
Copy link
Member

julienlim commented Feb 15, 2018

Volumes list should include Volume Profiling column and Enable/Disable Profiling action button. See https://redhat.invisionapp.com/share/8QCOEVEY9#/screens/244738623.

Related to the following GitHub Issues:

@gnehapk @a2batic @nthomas-redhat @mcarrano @Tendrl/tendrl-qe

@gnehapk
Copy link
Member

gnehapk commented Feb 19, 2018

@julienlim @mbukatov I feel the Enable/Disable Profiling action should be in the kabab menu similar to cluster list view to make the experience consistent across all the screens.

@mcarrano
Copy link

I think you make a fair point @gnehapk . We did this because we don't expect to add further actions to the Volume list view and it seemed off to have the kabob menu with only one action.

@shtripat
Copy link
Member

Just a note in case of individual volumes, its handled bit differently from backend as it submits a job while enable and disable profiling is called for a volume. So volume entity would have a current_job details and based on that we need to display that info in UI as well. If there is a job submitted for enable profiling we should the status of the job for the volume.

@julienlim @mcarrano so we would need UX designs for the same to show job status for a volume.

@mcarrano
Copy link

We have updated the Volumes list view as follows:

  • While the task is in progress, the Volume Profiling field will show "Pending" with a link to the task details.
  • The Enable/Disable Profiling button will be disabled during this process.

You can see the updated designs here: https://redhat.invisionapp.com/share/8QCOEVEY9

@gnehapk gnehapk added this to the Milestone 3 (2018) milestone Mar 5, 2018
@gnehapk
Copy link
Member

gnehapk commented Mar 8, 2018

@julienlim Fixed with the milestone 3 release. Hence, closing it. Please open, if you see any issue,

@gnehapk gnehapk closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants