You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Conversion of video to gif won't do any compression of the video, that's why I have chosen the method name.
I agree with other suggestions with just a couple observations. cancelCompress should be cancelCompression. Renaming to an existing method name might be confusing to existing library users, maybe getThumbnailFile would be more appropriate?
I don't know how its working on backend, but as an user of the package, converting to gif looks like a compression cause it uses the compressProgress stream.
So maybe it should have a convertingProgress stream and a isConverting boolean.
And yeah, maybe getThumbnailFile is more appropriate.
About old users from the library, you can delegate the method with the old method name with a warning that it will be deprecated.
But if you gonna think on renaming these things maybe the package should call Flutter Video Manager cause it's not just compressing it's also converting and etc haha
Obs: the package is awesome and it is extremely needed for my project, thanks a lot for this work.
I saw that you owners are not americans and maybe thats the reason the methods don't have a intuitive name.
My suggestions for rename:
startCompress -> compressVideo
convertVideoToGif -> compressVideoToGif
stopCompress -> cancelCompress
getThumbnail -> getThumbnailBytesList
getThumbnailWithFile -> getThumbnail
The text was updated successfully, but these errors were encountered: