Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Chart (formerly pack bubbles) #6

Closed
JoshSchoen opened this issue Aug 20, 2018 · 3 comments
Closed

Graph Chart (formerly pack bubbles) #6

JoshSchoen opened this issue Aug 20, 2018 · 3 comments
Assignees
Milestone

Comments

@JoshSchoen
Copy link
Contributor

Feature Request

Example from, Tableau: screen shot 2018-08-20 at 5 19 49 pm

Considerations

  • Configurable legend placement
  • Color inputs options
  • interfaces to describe the configuration options for good dev UX.
  • custom tooltips and legend formatting
  • label fonts and theming
  • Event emitters to facilitate cross filtering
  • annotations
@jeremysmartt jeremysmartt added this to To do in Covalent 2.0.0 via automation Sep 13, 2018
@jeremysmartt jeremysmartt added this to the Release 2.0.0 milestone Sep 13, 2018
@JoshSchoen
Copy link
Contributor Author

@kyleledbetter @emoralesb05 After spending a little time looking into this I think it makes sense to close this issue in favor of a new issue to implement a graph atomic component as we can use the echarts graph series type with some helper functions to provide the x/y coordinates and the symbol size.

I added a stackbltiz as a simple example. It uses d3-hierarchy and pack as dependencies to calculate the packing layout. To me this is an implementation detail for specific use cases and layout requirements so I don't think this belongs on the library side.

There are also some responsive design considerations when using d3-hierarchy as it may need to recalculate the bubble sizes for smaller screens. In which case it's arguably be better for the developer to control that on the implementation side and leverage covalent's media service or handle it in another way.

I'm curious to see what you guys think. If you agree, I will close this issue open a new graph atomic component issues which is almost complete other than updating the docs readme file.

Thanks!

@jeremysmartt
Copy link
Collaborator

@JoshSchoen Feel free to modify this issue rather than open a new one.

@JoshSchoen JoshSchoen changed the title Packed Bubble Chart Graph Chart (formerly pack bubbles) Nov 6, 2018
@JoshSchoen JoshSchoen self-assigned this Nov 16, 2018
@JoshSchoen JoshSchoen moved this from To do to In progress in Covalent 2.0.0 Nov 16, 2018
@JoshSchoen JoshSchoen moved this from In progress to Needs Review in Covalent 2.0.0 Nov 18, 2018
Covalent 2.0.0 automation moved this from Needs Review to Done Nov 20, 2018
@emoralesb05
Copy link
Collaborator

Taken care of with #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants