Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(material): Upgrade to latest material. (closes #346) #305

Merged
merged 65 commits into from Feb 23, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Feb 1, 2017

Description

Upgrade to latest @angular/material@2.0.0-beta.2. https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta2-flannel-papaya-2017-02-15

What's included?

Material Changes:

  • Breaking change from material where md-input has been removed as component and directive in favor of the mdInput directive selector.
  • Leverage new input of md-menu [overlapTrigger]="false" in notifications demo so the menu doesnt overlap the icon
  • Now we can use the (change) event from md-select.

Covalent Changes/Fixes because of material:

  • internal(efficiency): No more need for refresh work around for tooltips used under OnPush angular/components@632b964
  • bugfix(layout): Leverage disableClose input from sidenav to prevent ESC closing the sidenav on side mode. angular/components@52ade97
  • bugfix(dynamic-forms): number type input works again.
  • feature(data-table): Leverage the md-pseudo-checkbox to render the selectable rows more efficiently. angular/components@3b6cab0

Test Steps

  • npm run reinstall
  • ng serve
  • Play around with docs

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

NOTE: Needs heavy testing on all fronts since the .mat prefix change affected how certain rules are applied.

@emoralesb05 emoralesb05 mentioned this pull request Feb 2, 2017
7 tasks
Copy link
Contributor

@kyleledbetter kyleledbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotta work here, LGTM

@emoralesb05 emoralesb05 changed the title feature(material): Upgrade to latest material. feature(material): Upgrade to latest material. (closes #346) Feb 23, 2017
@emoralesb05 emoralesb05 merged commit 717d309 into develop Feb 23, 2017
@emoralesb05 emoralesb05 deleted the feature/upgrade-material branch February 23, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants